Skip to content

Initial implementation of improved image sizes algorithm - #1250

Merged
mukeshpanchal27 merged 9 commits into
feature/more-accurate-sizes-attributefrom
fix/1187-accurate-sizes-image-cover-block
Jun 5, 2024
Merged

Initial implementation of improved image sizes algorithm#1250
mukeshpanchal27 merged 9 commits into
feature/more-accurate-sizes-attributefrom
fix/1187-accurate-sizes-image-cover-block

Conversation

@mukeshpanchal27

Copy link
Copy Markdown
Member

Summary

Fixes #1187

@mukeshpanchal27 mukeshpanchal27 added [Type] Feature A new feature within an existing module no milestone PRs that do not have a defined milestone for release [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) labels May 27, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this May 27, 2024
@mukeshpanchal27
mukeshpanchal27 requested a review from joemcgill May 27, 2024 10:38
@joemcgill joemcgill linked an issue May 28, 2024 that may be closed by this pull request
3 tasks
Comment thread plugins/auto-sizes/hooks.php Outdated
Comment thread plugins/auto-sizes/hooks.php Outdated
Comment thread plugins/auto-sizes/hooks.php Outdated

@joemcgill joemcgill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! I think it would be good to add some tests for these early on so we can make sure we're getting the output we expect.

Comment thread plugins/auto-sizes/hooks.php Outdated
@mukeshpanchal27
mukeshpanchal27 marked this pull request as ready for review June 3, 2024 08:11
@github-actions

github-actions Bot commented Jun 3, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@joemcgill joemcgill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good first implementation and tests well. I've left a few suggestions about improving the tests, but I think this is pretty close to merge so we have a base in the feature branch to work against.

Comment thread plugins/auto-sizes/tests/improve-sizes-test.php Outdated
Comment thread plugins/auto-sizes/tests/improve-sizes-test.php Outdated
Comment thread plugins/auto-sizes/hooks.php Outdated
Comment thread plugins/auto-sizes/hooks.php Outdated
Comment thread plugins/auto-sizes/hooks.php Outdated

@joemcgill joemcgill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, but I think this is good. Pre-approving.

Comment thread plugins/auto-sizes/tests/improve-sizes-test.php Outdated
@mukeshpanchal27
mukeshpanchal27 merged commit 5f1664e into feature/more-accurate-sizes-attribute Jun 5, 2024
@mukeshpanchal27
mukeshpanchal27 deleted the fix/1187-accurate-sizes-image-cover-block branch June 5, 2024 04:18
@westonruter westonruter removed the no milestone PRs that do not have a defined milestone for release label Jul 10, 2024
@westonruter westonruter added this to the auto-sizes 1.1.0 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) [Type] Feature A new feature within an existing module

3 participants