Skip to content

Remove obsolete fallback script now that picture element is supported - #1269

Merged
westonruter merged 3 commits into
WordPress:trunkfrom
Anuj-Rathore24:trunk
Jun 3, 2024
Merged

Remove obsolete fallback script now that picture element is supported#1269
westonruter merged 3 commits into
WordPress:trunkfrom
Anuj-Rathore24:trunk

Conversation

@Anuj-Rathore24

Copy link
Copy Markdown
Contributor

Summary

Remove Fallback Script which was used to replace webp images with jpeg alternatives on older browsers.
Fixes #996

Relevant technical choices

  • Remove the fallback File.
  • Remove Function webpUploadsDetectFallback and the action associate with this.
Removed the webpUploadsDetectFallback function and the associated foreach loop that adds actions for this function.
@github-actions

github-actions Bot commented Jun 3, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Anuj-Rathore24 <anujrathore24@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter

Copy link
Copy Markdown
Member

Looks like this test case needs to be removed as well: Test_WebP_Uploads_Load::test_it_should_add_fallback_script_if_content_has_updated_images

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Jun 3, 2024
@westonruter westonruter added this to the webp-uploads 2.0.0 milestone Jun 3, 2024
	- Remove Test case that checks that the fallback script is added when a post with updated images is rendered.

@westonruter westonruter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@westonruter
westonruter merged commit 75a6282 into WordPress:trunk Jun 3, 2024
@westonruter westonruter changed the title Remove Fallback Script Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature

2 participants