Skip to content

Expand pull filters into path selections - #434

Draft
adamziel wants to merge 1 commit into
adamziel/files-pull-excludefrom
adamziel/filter-skipped-files
Draft

Expand pull filters into path selections#434
adamziel wants to merge 1 commit into
adamziel/files-pull-excludefrom
adamziel/filter-skipped-files

Conversation

@adamziel

@adamziel adamziel commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

--filter=essential-files now expands to --exclude=:wp-uploads:, while --filter=skipped-earlier expands to --only=:wp-uploads:.

This removes the secondary skipped-file list and checkpoint. skipped-earlier no longer requires a prior run, and completed pulls can switch filters as a new path-selected delta. The compatibility option remains accepted but is omitted from command help. On load, old skipped-list fields are discarded while the existing path-selection fingerprint remains unchanged.

Stacked on #437.

Testing

(cd tests && ../vendor/bin/phpunit Import)
php vendor/bin/phpstan analyze --memory-limit=1G
vendor/bin/phpcs --standard=PHPCompatibility --runtime-set testVersion 7.4- -ps packages/reprint-importer/src
git diff --check
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Pull pipeline performance — large-directory

Site: large-directory · 2,000+ plus targeted file-transfer scenarios files · 10,000 posts · 25,000 postmeta · PHP 8.5.9

trunk baseline unavailable — showing PR numbers only.

Stage Wall time Resume attempts Status Details
playground-sqlite-db-pull 9.72 s 1 condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
playground-sqlite-db-apply 3.58 s 1 condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
Total 13.30 s

Numbers carry runner noise; treat single-run deltas as directional, not authoritative.

📈 Trunk performance history — commit-by-commit timeline.

@adamziel
adamziel force-pushed the adamziel/filter-skipped-files branch 2 times, most recently from c5f8335 to 1f644eb Compare July 31, 2026 00:50
@adamziel adamziel changed the title Replace skipped-file state with path filters Jul 31, 2026
@adamziel
adamziel changed the base branch from trunk to adamziel/files-pull-exclude July 31, 2026 00:50
@adamziel
adamziel force-pushed the adamziel/files-pull-exclude branch from fdc2037 to 7e4d1ec Compare July 31, 2026 10:24
@adamziel
adamziel force-pushed the adamziel/filter-skipped-files branch from 1f644eb to 27a1daf Compare July 31, 2026 10:27
@adamziel
adamziel force-pushed the adamziel/files-pull-exclude branch from 7e4d1ec to 04d3f6b Compare July 31, 2026 14:57
@adamziel
adamziel force-pushed the adamziel/filter-skipped-files branch from 27a1daf to b4281a1 Compare July 31, 2026 15:07
@adamziel
adamziel force-pushed the adamziel/files-pull-exclude branch from 04d3f6b to 5fb70aa Compare July 31, 2026 15:31
@adamziel
adamziel force-pushed the adamziel/filter-skipped-files branch from b4281a1 to 846efae Compare July 31, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant