Inline was_mutated flag on native parser node hot path - #390
Merged
Conversation
Drop the trivial getter and read the property directly. The check fires on every read of a native-backed node, so saving a method call adds up on full-tree traversals.
Merged
JanJakes
added a commit
that referenced
this pull request
Jun 19, 2026
## Release `3.0.0-rc.4` Version bump and changelog update for release `3.0.0-rc.4`. **Changelog draft:** * Normalize BIT column default literals ([#439](#439)) * Optimize MySQL lexer (~2× speedup) ([#424](#424)) * Fix `RAND()` function behavior ([#363](#363)) * CI: Disable Xdebug, use Rust release builds, consolidate unit-test matrix ([#425](#425)) * GitHub Actions workflow updates ([#404](#404)) * Add native Rust-based MySQL parser extension ([#381](#381), [#384](#384), [#386](#386), [#389](#389), [#390](#390), [#394](#394), [#398](#398)) * Ship native parser as WASM ([#395](#395), [#396](#396), [#397](#397), [#399](#399), [#400](#400), [#401](#401)) * Add SQLite plugin landing page ([#407](#407), [#412](#412)) * Check Playground web runtime compatibility ([#419](#419)) **Full changelog:** v3.0.0-rc.3...release/v3.0.0-rc.4 ## Next steps 1. **Review** the changes in this pull request. 2. **Push** any additional edits to this branch (`release/v3.0.0-rc.4`). 3. **Merge** this pull request to complete the release. Merging will automatically build the plugin ZIP and create a [GitHub release](https://github.com/WordPress/sqlite-database-integration/releases). > [!NOTE] > This is a **pre-release**. It will not be deployed to [WordPress.org](https://wordpress.org/plugins/sqlite-database-integration/).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop the
was_mutated()getter fromWP_MySQL_Native_Parser_Nodeand read the property directly. The flag is checked on every read of a native-backed node, so a method call per access shows up on full-tree traversals.The naming still reads at the call sites (
if ( \$this->was_mutated )), so we don't lose anything by inlining.