Skip to content

Make SubjectsApi automatically figure out which endpoints to call #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2024
Merged

Make SubjectsApi automatically figure out which endpoints to call #160

merged 1 commit into from
Dec 13, 2024

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Dec 12, 2024 •
edited
Loading

Fixes #156

This one turned out to be very simple.
@psrpinto psrpinto changed the base branch from trunk to ui-using-schema December 12, 2024 17:06
@psrpinto psrpinto self-assigned this Dec 12, 2024
@psrpinto psrpinto linked an issue Dec 12, 2024 that may be closed by this pull request
SubjectsApi should automatically figure out which endpoints to call #156
Closed
@psrpinto psrpinto force-pushed the frontend-subject-api-generic branch from 9d78369 to f7caad6 Compare December 12, 2024 17:14
@psrpinto psrpinto marked this pull request as ready for review December 12, 2024 17:14
@psrpinto psrpinto requested review from akirk and ashfame December 12, 2024 17:15
@psrpinto
Copy link
Member Author

psrpinto commented Dec 12, 2024 •
edited
Loading

Note that the fields are still hardcoded when updating the subject. Opened #161 to track that.
@psrpinto psrpinto mentioned this pull request Dec 13, 2024
Merged
Base automatically changed from ui-using-schema to trunk December 13, 2024 15:44
@psrpinto psrpinto merged commit 24b2fe8 into trunk Dec 13, 2024
3 checks passed
@psrpinto psrpinto deleted the frontend-subject-api-generic branch December 13, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@psrpinto @ashfame