Tweak variations to remove explicit color references by richtabor · Pull Request #619 · WordPress/twentytwentyfive

richtabor · 2024-10-22T15:03:11Z

Description

Closes #620.

Using currentColor allows for colors to be manipulated manually within the Inspector. Otherwise users are required to modify text and link colors, which feels broken as the text and link colors are the same value to start.

Testing Instructions

Test each color and full style variation across each section style.

github-actions · 2024-10-22T15:03:22Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: beafialho <beafialho@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-10-22T15:03:25Z

Preview changes

You can preview these changes by following the link below:

Preview changes for twentytwentyfive

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

carolinan · 2024-10-22T15:22:55Z

Please show that all the color contrasts have been tested.

richtabor · 2024-10-22T15:24:05Z

Please show that all the color contrasts have been tested.

I asked @beafialho to review, thanks.

beafialho · 2024-10-22T15:42:07Z

I noticed a few places where links seem to have specific settings and aren't contrasting:

Noon: Site Title, Title (Post title), Comments Title, Comment Author, Comment Date, Comment Reply Link, Comment Edit Link and Post Date
Midnight, Afternoon, Evening, Twilight: Comment Author, Comment Date, Comment Reply Link, Comment Edit Link and Post Date
Dusk, Sunrise, Morning: Comment Author, Comment Date and Post Date

juanfra

Thanks for working on this, Rich! It's looking good.

I've been through the different variations, and here are my findings:

Evening

Style 3 - link - Very low contrast (3.24:1)
Style 4 - link - Very low contrast (1.07:1)
Style 5 - link - Very low contrast (1.42:1)

Before	After

Noon

Style 4 - Headings - Very low contrast (1:1)
Style 5 - Headings - Very low contrast (1:1)

Before	After

juanfra · 2024-10-25T16:52:58Z

@richtabor @beafialho I've pushed a commit with changes to fix the parity that we had since this PR, and that should also be fixing the contrast issues I've found.

Rich, feel free to revert if you find any issues. Bea, if you can please give this another go and see if everything looks good on your end.

Thanks 🙌

beafialho · 2024-10-26T10:33:17Z

Thank you!

I only noticed issues in Noon Section Style 4 (the one with a black background). I believe it must be because Noon has the Headings and Post Titles color defined as #191919. They should indeed be that color, do you think there's a way to keep that color but make it work on this section style? If not, we can adjust accordingly but just to try to stick with the design intention.

noon-contrast-issues.mp4

juanfra · 2024-10-29T17:08:02Z

Thanks @beafialho - I just pushed a change that should fix that.

beafialho · 2024-10-30T09:50:01Z

Thank you @juanfra, the issues I mentioned in Noon are solved now!

beafialho · 2024-10-30T10:45:40Z

Can we also make sure the Quote block's colors are looking/working ideally? For more context.

juanfra · 2024-10-30T14:23:42Z

@beafialho I just pushed a change that should fix the quote block issue for all sections in all variations.

Screen.Recording.2024-10-30.at.15.21.34.mov

beafialho · 2024-10-30T15:02:12Z

Thank you for your patience on this one @juanfra. This one is a tricky one to test because you need to have all the blocks listed out on the same page to get the view. I have noticed on my site that Post Date is still using a fixed color and Pullquote seems too as well. 🫠

I'm not sure about the Code block, but it seems to have a fixed color as well:

code.mp4

Apologies for the back and forth but hopefully after these are addressed this is ready to merge.

juanfra · 2024-10-30T15:59:52Z

@beafialho I pushed a fix for the pullquote in the different section styles.

Could you please clarify the expected behavior for the code and post-date blocks? Where are you taking those screencasts from?

beafialho · 2024-10-30T17:25:11Z

Could you please clarify the expected behavior for the code and post-date blocks? Where are you taking those screencasts from?

The Code block should always have a slightly lighter or darker color than the background (usually Tertiary). And the Post Date should just have an accessible color.

carolinan · 2024-10-31T03:18:51Z

I have seen the code block issue: I let it slide because the text is always visible on all variations, so it is still accessible.

beafialho · 2024-10-31T09:23:29Z

Yes, the code block isn't necessarily a bug because it is readable.

juanfra · 2024-10-31T10:27:44Z

Ok, I pushed changes for the date block, and left the code block as is. For the date block on different sections, I chose the current color at 85%.

Code to test

<!-- wp:group {"metadata":{"name":"Style 1"},"className":"is-style-section-1","style":{"spacing":{"padding":{"top":"var:preset|spacing|30","bottom":"var:preset|spacing|30","left":"var:preset|spacing|30","right":"var:preset|spacing|30"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group is-style-section-1" style="padding-top:var(--wp--preset--spacing--30);padding-right:var(--wp--preset--spacing--30);padding-bottom:var(--wp--preset--spacing--30);padding-left:var(--wp--preset--spacing--30)"><!-- wp:paragraph -->
<p>Style 1</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:group {"metadata":{"name":"Style 2"},"className":"is-style-section-2","style":{"spacing":{"padding":{"top":"var:preset|spacing|30","bottom":"var:preset|spacing|30","left":"var:preset|spacing|30","right":"var:preset|spacing|30"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group is-style-section-2" style="padding-top:var(--wp--preset--spacing--30);padding-right:var(--wp--preset--spacing--30);padding-bottom:var(--wp--preset--spacing--30);padding-left:var(--wp--preset--spacing--30)"><!-- wp:paragraph -->
<p>Style 2</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:group {"metadata":{"name":"Style 3"},"className":"is-style-section-3","style":{"spacing":{"padding":{"top":"var:preset|spacing|30","bottom":"var:preset|spacing|30","left":"var:preset|spacing|30","right":"var:preset|spacing|30"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group is-style-section-3" style="padding-top:var(--wp--preset--spacing--30);padding-right:var(--wp--preset--spacing--30);padding-bottom:var(--wp--preset--spacing--30);padding-left:var(--wp--preset--spacing--30)"><!-- wp:paragraph -->
<p>Style 3</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:group {"metadata":{"name":"Style 4"},"className":"is-style-section-4","style":{"spacing":{"padding":{"top":"var:preset|spacing|30","bottom":"var:preset|spacing|30","left":"var:preset|spacing|30","right":"var:preset|spacing|30"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group is-style-section-4" style="padding-top:var(--wp--preset--spacing--30);padding-right:var(--wp--preset--spacing--30);padding-bottom:var(--wp--preset--spacing--30);padding-left:var(--wp--preset--spacing--30)"><!-- wp:paragraph -->
<p>Style 4</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:group {"metadata":{"name":"Style 5"},"className":"is-style-section-5","style":{"spacing":{"padding":{"top":"var:preset|spacing|30","bottom":"var:preset|spacing|30","left":"var:preset|spacing|30","right":"var:preset|spacing|30"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group is-style-section-5" style="padding-top:var(--wp--preset--spacing--30);padding-right:var(--wp--preset--spacing--30);padding-bottom:var(--wp--preset--spacing--30);padding-left:var(--wp--preset--spacing--30)"><!-- wp:paragraph -->
<p>Style 5</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:group {"className":"is-style-default","layout":{"type":"constrained"}} -->
<div class="wp-block-group is-style-default"><!-- wp:buttons -->
<div class="wp-block-buttons"><!-- wp:button -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button">Standard button</a></div>
<!-- /wp:button -->

<!-- wp:button {"className":"is-style-outline"} -->
<div class="wp-block-button is-style-outline"><a class="wp-block-button__link wp-element-button">Outline</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons --></div>
<!-- /wp:group -->

<!-- wp:group {"className":"is-style-section-1","style":{"spacing":{"padding":{"top":"var:preset|spacing|50","bottom":"var:preset|spacing|50","left":"var:preset|spacing|50","right":"var:preset|spacing|50"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group is-style-section-1" style="padding-top:var(--wp--preset--spacing--50);padding-right:var(--wp--preset--spacing--50);padding-bottom:var(--wp--preset--spacing--50);padding-left:var(--wp--preset--spacing--50)"><!-- wp:heading {"level":3} -->
<h3 class="wp-block-heading">Heading - Style 1</h3>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>Section style 1 (but with extra padding...). And <a href="#">a link</a></p>
<!-- /wp:paragraph -->

<!-- wp:group {"layout":{"type":"flex","orientation":"vertical"}} -->
<div class="wp-block-group"><!-- wp:paragraph {"className":"is-style-pill is-style-text-annotation"} -->
<p class="is-style-pill is-style-text-annotation">Annotation style</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:buttons -->
<div class="wp-block-buttons"><!-- wp:button -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button" href="#">A standard button</a></div>
<!-- /wp:button -->

<!-- wp:button {"className":"is-style-outline"} -->
<div class="wp-block-button is-style-outline"><a class="wp-block-button__link wp-element-button" href="#">An outlined button</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons -->

<!-- wp:quote -->
<blockquote class="wp-block-quote"><!-- wp:paragraph {"style":{"typography":{"writingMode":"horizontal-tb"}}} -->
<p style="writing-mode:horizontal-tb">“Early in my career...I had to choose between an honest <a href="http://blocks.local/section-styles/" data-type="page" data-id="3437">arrogance</a> and a hypercritical humility... I deliberately choose an honest arrogance, and I've never been sorry.”</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"fontSize":"small"} -->
<p class="has-small-font-size">Frank Lloyd Wright</p>
<!-- /wp:paragraph --></blockquote>
<!-- /wp:quote -->

<!-- wp:pullquote -->
<figure class="wp-block-pullquote"><blockquote><p>“Early in my career...I had to choose between an honest <a href="http://blocks.local/section-styles/" data-type="page" data-id="3437">arrogance</a> and a hypercritical humility... I deliberately choose an honest arrogance, and I've never been sorry.”</p><cite>Frank Lloyd Wright</cite></blockquote></figure>
<!-- /wp:pullquote -->

<!-- wp:post-date /--></div>
<!-- /wp:group -->

<!-- wp:group {"className":"is-style-section-2","style":{"spacing":{"padding":{"top":"var:preset|spacing|50","bottom":"var:preset|spacing|50","left":"var:preset|spacing|50","right":"var:preset|spacing|50"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group is-style-section-2" style="padding-top:var(--wp--preset--spacing--50);padding-right:var(--wp--preset--spacing--50);padding-bottom:var(--wp--preset--spacing--50);padding-left:var(--wp--preset--spacing--50)"><!-- wp:heading {"level":3} -->
<h3 class="wp-block-heading">Heading - Style 2</h3>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>Section style 2 (but with extra padding...). And <a href="#">a link</a></p>
<!-- /wp:paragraph -->

<!-- wp:group {"layout":{"type":"flex","orientation":"vertical"}} -->
<div class="wp-block-group"><!-- wp:paragraph {"className":"is-style-pill is-style-text-annotation"} -->
<p class="is-style-pill is-style-text-annotation">Annotation style</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:buttons -->
<div class="wp-block-buttons"><!-- wp:button -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button" href="#">A standard button</a></div>
<!-- /wp:button -->

<!-- wp:button {"className":"is-style-outline"} -->
<div class="wp-block-button is-style-outline"><a class="wp-block-button__link wp-element-button" href="#">An outlined button</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons -->

<!-- wp:quote -->
<blockquote class="wp-block-quote"><!-- wp:paragraph {"style":{"typography":{"writingMode":"horizontal-tb"}}} -->
<p style="writing-mode:horizontal-tb">“Early in my career...I had to choose between an honest <a href="http://blocks.local/section-styles/" data-type="page" data-id="3437">arrogance</a> and a hypercritical humility... I deliberately choose an honest arrogance, and I've never been sorry.”</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"fontSize":"small"} -->
<p class="has-small-font-size">Frank Lloyd Wright</p>
<!-- /wp:paragraph --></blockquote>
<!-- /wp:quote -->

<!-- wp:pullquote -->
<figure class="wp-block-pullquote"><blockquote><p>“Early in my career...I had to choose between an honest <a href="http://blocks.local/section-styles/" data-type="page" data-id="3437">arrogance</a> and a hypercritical humility... I deliberately choose an honest arrogance, and I've never been sorry.”</p><cite>Frank Lloyd Wright</cite></blockquote></figure>
<!-- /wp:pullquote -->

<!-- wp:post-date /--></div>
<!-- /wp:group -->

<!-- wp:group {"className":"is-style-section-3","style":{"spacing":{"padding":{"top":"var:preset|spacing|50","bottom":"var:preset|spacing|50","left":"var:preset|spacing|50","right":"var:preset|spacing|50"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group is-style-section-3" style="padding-top:var(--wp--preset--spacing--50);padding-right:var(--wp--preset--spacing--50);padding-bottom:var(--wp--preset--spacing--50);padding-left:var(--wp--preset--spacing--50)"><!-- wp:heading {"level":3} -->
<h3 class="wp-block-heading">Heading - Style 3</h3>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>Section style 3 (but with extra padding...). And <a href="#">a link</a></p>
<!-- /wp:paragraph -->

<!-- wp:group {"layout":{"type":"flex","orientation":"vertical"}} -->
<div class="wp-block-group"><!-- wp:paragraph {"className":"is-style-pill is-style-text-annotation"} -->
<p class="is-style-pill is-style-text-annotation">Annotation style</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:buttons -->
<div class="wp-block-buttons"><!-- wp:button -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button" href="#">A standard button</a></div>
<!-- /wp:button -->

<!-- wp:button {"className":"is-style-outline"} -->
<div class="wp-block-button is-style-outline"><a class="wp-block-button__link wp-element-button" href="#">An outlined button</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons -->

<!-- wp:quote -->
<blockquote class="wp-block-quote"><!-- wp:paragraph {"style":{"typography":{"writingMode":"horizontal-tb"}}} -->
<p style="writing-mode:horizontal-tb">“Early in my career...I had to choose between an honest <a href="http://blocks.local/section-styles/" data-type="page" data-id="3437">arrogance</a> and a hypercritical humility... I deliberately choose an honest arrogance, and I've never been sorry.”</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"fontSize":"small"} -->
<p class="has-small-font-size">Frank Lloyd Wright</p>
<!-- /wp:paragraph --></blockquote>
<!-- /wp:quote -->

<!-- wp:pullquote -->
<figure class="wp-block-pullquote"><blockquote><p>“Early in my career...I had to choose between an honest <a href="http://blocks.local/section-styles/" data-type="page" data-id="3437">arrogance</a> and a hypercritical humility... I deliberately choose an honest arrogance, and I've never been sorry.”</p><cite>Frank Lloyd Wright</cite></blockquote></figure>
<!-- /wp:pullquote -->

<!-- wp:post-date /--></div>
<!-- /wp:group -->

<!-- wp:group {"className":"is-style-section-4","style":{"spacing":{"padding":{"top":"var:preset|spacing|50","bottom":"var:preset|spacing|50","left":"var:preset|spacing|50","right":"var:preset|spacing|50"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group is-style-section-4" style="padding-top:var(--wp--preset--spacing--50);padding-right:var(--wp--preset--spacing--50);padding-bottom:var(--wp--preset--spacing--50);padding-left:var(--wp--preset--spacing--50)"><!-- wp:heading {"level":3} -->
<h3 class="wp-block-heading">Heading - Style 4</h3>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>Section style 4 (but with extra padding...). And <a href="#">a link</a></p>
<!-- /wp:paragraph -->

<!-- wp:group {"layout":{"type":"flex","orientation":"vertical"}} -->
<div class="wp-block-group"><!-- wp:paragraph {"className":"is-style-pill is-style-text-annotation"} -->
<p class="is-style-pill is-style-text-annotation">Annotation style</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:buttons -->
<div class="wp-block-buttons"><!-- wp:button -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button" href="#">A standard button</a></div>
<!-- /wp:button -->

<!-- wp:button {"className":"is-style-outline"} -->
<div class="wp-block-button is-style-outline"><a class="wp-block-button__link wp-element-button" href="#">An outlined button</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons -->

<!-- wp:quote -->
<blockquote class="wp-block-quote"><!-- wp:paragraph {"style":{"typography":{"writingMode":"horizontal-tb"}}} -->
<p style="writing-mode:horizontal-tb">“Early in my career...I had to choose between an honest <a href="http://blocks.local/section-styles/" data-type="page" data-id="3437">arrogance</a> and a hypercritical humility... I deliberately choose an honest arrogance, and I've never been sorry.”</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"fontSize":"small"} -->
<p class="has-small-font-size">Frank Lloyd Wright</p>
<!-- /wp:paragraph --></blockquote>
<!-- /wp:quote -->

<!-- wp:pullquote -->
<figure class="wp-block-pullquote"><blockquote><p>“Early in my career...I had to choose between an honest <a href="http://blocks.local/section-styles/" data-type="page" data-id="3437">arrogance</a> and a hypercritical humility... I deliberately choose an honest arrogance, and I've never been sorry.”</p><cite>Frank Lloyd Wright</cite></blockquote></figure>
<!-- /wp:pullquote -->

<!-- wp:post-date /--></div>
<!-- /wp:group -->

<!-- wp:group {"className":"is-style-section-5","style":{"spacing":{"padding":{"top":"var:preset|spacing|50","bottom":"var:preset|spacing|50","left":"var:preset|spacing|50","right":"var:preset|spacing|50"}}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group is-style-section-5" style="padding-top:var(--wp--preset--spacing--50);padding-right:var(--wp--preset--spacing--50);padding-bottom:var(--wp--preset--spacing--50);padding-left:var(--wp--preset--spacing--50)"><!-- wp:heading {"level":3} -->
<h3 class="wp-block-heading">Heading - Style 5</h3>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>Section style 5 (but with extra padding...). And <a href="#">a link</a></p>
<!-- /wp:paragraph -->

<!-- wp:group {"layout":{"type":"flex","orientation":"vertical"}} -->
<div class="wp-block-group"><!-- wp:paragraph {"className":"is-style-pill is-style-text-annotation"} -->
<p class="is-style-pill is-style-text-annotation">Annotation style</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:buttons -->
<div class="wp-block-buttons"><!-- wp:button -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button" href="#">A standard button</a></div>
<!-- /wp:button -->

<!-- wp:button {"className":"is-style-outline"} -->
<div class="wp-block-button is-style-outline"><a class="wp-block-button__link wp-element-button" href="#">An outlined button</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons -->

<!-- wp:quote -->
<blockquote class="wp-block-quote"><!-- wp:paragraph {"style":{"typography":{"writingMode":"horizontal-tb"}}} -->
<p style="writing-mode:horizontal-tb">“Early in my career...I had to choose between an honest <a href="http://blocks.local/section-styles/" data-type="page" data-id="3437">arrogance</a> and a hypercritical humility... I deliberately choose an honest arrogance, and I've never been sorry.”</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"fontSize":"small"} -->
<p class="has-small-font-size">Frank Lloyd Wright</p>
<!-- /wp:paragraph --></blockquote>
<!-- /wp:quote -->

<!-- wp:pullquote -->
<figure class="wp-block-pullquote"><blockquote><p>“Early in my career...I had to choose between an honest <a href="http://blocks.local/section-styles/" data-type="page" data-id="3437">arrogance</a> and a hypercritical humility... I deliberately choose an honest arrogance, and I've never been sorry.”</p><cite>Frank Lloyd Wright</cite></blockquote></figure>
<!-- /wp:pullquote -->

<!-- wp:post-date /--></div>
<!-- /wp:group -->

Screen.Recording.2024-10-31.at.11.22.58.mov

beafialho · 2024-10-31T10:49:31Z

Thank you! It's working now, the slight opacity gives it exactly the intended look 🚀 If it's easy, I wonder if we could use the same approach for the code block background? If not, we can just move on.

juanfra · 2024-10-31T12:28:04Z

Thank you! It's working now, the slight opacity gives it exactly the intended look 🚀 If it's easy, I wonder if we could use the same approach for the code block background? If not, we can just move on.

@beafialho That's not possible on backgrounds, as we're using currentColor, which takes the color property.

juanfra · 2024-11-04T11:07:55Z

After discussing this with Carolina and Bea, we're merging it.

Rich Tabor added 5 commits October 22, 2024 16:29

remove duplicate overriding json

2522f2b

noon

47cbc57

use current color instead of fixed colors

1847dd2

apply current color to variations post author and terms

c983dcf

more

c566bf8

richtabor added the [Type] Bug An existing feature does not function as intended. label Oct 22, 2024

richtabor requested review from carolinan and juanfra October 22, 2024 15:23

richtabor requested a review from beafialho October 22, 2024 15:24

site title

76dd271

juanfra reviewed Oct 23, 2024

View reviewed changes

juanfra added 3 commits October 24, 2024 16:37

Merge branch 'trunk' into tweak/variations

ef12628

Merge branch 'trunk' into tweak/variations

52211b1

Fix parity between variations and color files. Fix contrast issues.

d080fe1

account for more blocks with custom colors

187acd0

carolinan mentioned this pull request Oct 29, 2024

Post Date block color are not visible for some color variations and sections style 5. #657

Closed

juanfra added 2 commits October 29, 2024 18:02

Merge branch 'trunk' into tweak/variations

46c4152

Noon: Set heading color for section 4 to currentColor

bbc2e87

carolinan mentioned this pull request Oct 30, 2024

Ensure Quote Block Borders are Visible Across All Color Variations and Sections #654

Closed

Fix quote text color and border color.

87117f4

Fix the text color for the pull quote in the different section styles.

e125502

Update link colors for quote and pullquote in section styles.

864a03b

juanfra added 2 commits October 31, 2024 11:21

Remove link styles as not needed.

2718fe1

Set color for post date in the different variations.

fc3c6a8

juanfra merged commit 40b5281 into trunk Nov 4, 2024

juanfra deleted the tweak/variations branch November 4, 2024 11:08

juanfra mentioned this pull request Nov 4, 2024

The borders of the quote block are not visible for some color variations and sections. #653

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tweak variations to remove explicit color references - #619

Tweak variations to remove explicit color references #619
juanfra merged 17 commits into
trunkfrom
tweak/variations

richtabor commented Oct 22, 2024 •

edited

Loading

github-actions Bot commented Oct 22, 2024 •

edited

Loading

github-actions Bot commented Oct 22, 2024

carolinan commented Oct 22, 2024

richtabor commented Oct 22, 2024

beafialho commented Oct 22, 2024

juanfra left a comment

juanfra commented Oct 25, 2024

beafialho commented Oct 26, 2024

juanfra commented Oct 29, 2024

beafialho commented Oct 30, 2024

beafialho commented Oct 30, 2024

juanfra commented Oct 30, 2024 •

edited

Loading

beafialho commented Oct 30, 2024

juanfra commented Oct 30, 2024

beafialho commented Oct 30, 2024

carolinan commented Oct 31, 2024 •

edited

Loading

beafialho commented Oct 31, 2024

juanfra commented Oct 31, 2024

beafialho commented Oct 31, 2024

juanfra commented Oct 31, 2024

juanfra commented Nov 4, 2024

Labels

4 participants

Uh oh!

Conversation

richtabor commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

github-actions Bot commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

github-actions Bot commented Oct 22, 2024

Preview changes

carolinan commented Oct 22, 2024

richtabor commented Oct 22, 2024

beafialho commented Oct 22, 2024

juanfra left a comment

Choose a reason for hiding this comment

juanfra commented Oct 25, 2024

beafialho commented Oct 26, 2024

juanfra commented Oct 29, 2024

beafialho commented Oct 30, 2024

beafialho commented Oct 30, 2024

juanfra commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

beafialho commented Oct 30, 2024

juanfra commented Oct 30, 2024

beafialho commented Oct 30, 2024

carolinan commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

beafialho commented Oct 31, 2024

juanfra commented Oct 31, 2024

beafialho commented Oct 31, 2024

juanfra commented Oct 31, 2024

juanfra commented Nov 4, 2024

Labels

4 participants

richtabor commented Oct 22, 2024 •

edited

Loading

github-actions Bot commented Oct 22, 2024 •

edited

Loading

juanfra commented Oct 30, 2024 •

edited

Loading

carolinan commented Oct 31, 2024 •

edited

Loading