Code Quality: Use the null coalescing operator for isset() return checks - #12602
Code Quality: Use the null coalescing operator for isset() return checks#12602Soean wants to merge 1 commit into
Conversation
…cks.
Replace `if ( isset( $x ) ) { return $x; } else { return $default; }` patterns with the null coalescing operator (`??`).
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
Nice! How did we miss these before?
…turn checks.
This commit replaces a handful of verbose `isset()` guard patterns with the null coalescing operator (`??`):
{{{
#!php
<?php
// Before
if ( isset( $x ) ) {
return $x;
} else {
return $default;
}
// After
return $x ?? $default;
}}}
Both forms are functionally identical; `??` is shorter and clearer.
Developed in #12602.
Follow-up to [61463], [61470], [62870].
Props Soean, westonruter.
See #64897.
git-svn-id: https://develop.svn.wordpress.org/trunk@62895 602fd350-edb4-49c9-b593-d223f7449a82
|
Thanks for the PR! Merged in r62895. |
…turn checks.
This commit replaces a handful of verbose `isset()` guard patterns with the null coalescing operator (`??`):
{{{
#!php
<?php
// Before
if ( isset( $x ) ) {
return $x;
} else {
return $default;
}
// After
return $x ?? $default;
}}}
Both forms are functionally identical; `??` is shorter and clearer.
Developed in WordPress/wordpress-develop#12602.
Follow-up to [61463], [61470], [62870].
Props Soean, westonruter.
See #64897.
Built from https://develop.svn.wordpress.org/trunk@62895
git-svn-id: http://core.svn.wordpress.org/trunk@62162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
3 participants
Description
Replaces a handful of verbose
isset()guard patterns with the null coalescing operator (??):Both forms are functionally identical;
??is shorter and clearer.Notes
??.Trac ticket: https://core.trac.wordpress.org/ticket/64897
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.