Skip to content

Applying patch from jack-h2ml to current wp version #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Applying patch from jack-h2ml to current wp version #4788

wants to merge 3 commits into from

Conversation

gturpin-dev
Copy link

@gturpin-dev gturpin-dev commented Jul 4, 2023 •
edited
Loading

mukeshpanchal27
mukeshpanchal27 reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gturpin-dev for the PR, left some initial feedback.
gturpin-dev and others added 2 commits July 5, 2023 09:35
@gturpin-dev @mukeshpanchal27
Use str_starts_with instead of strpos for consistency
4fc69d2 
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@gturpin-dev @mukeshpanchal27
Using multiline comment for consistency
a63eb8b 
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@audrasjb audrasjb mentioned this pull request Jul 5, 2023
Closed
tellthemachines
tellthemachines approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and can confirm it works as expected in testing. Thanks for fixing this!
@audrasjb
Copy link
Contributor

Committed in https://core.trac.wordpress.org/changeset/56183
@audrasjb audrasjb closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@gturpin-dev @audrasjb @tellthemachines @mukeshpanchal27