Skip to content

Layout Support: Replace incremental IDs with hashes #8353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

DAreRodz
Copy link

@DAreRodz DAreRodz commented Feb 19, 2025

This is a backport PR for WordPress 6.8 that includes the following PHP Gutenberg changes:

Trac ticket: https://core.trac.wordpress.org/ticket/62985


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@joemcgill joemcgill marked this pull request as ready for review March 11, 2025 18:14
Copy link

github-actions bot commented Mar 11, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props darerodz, joemcgill.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code and additional tests look good to me.

It would be nice to add some addition test coverage specifically for the new wp_unique_id_from_values() function, similar to this test class, but I don't see that as a requirement for fixing the bug here.

@DAreRodz
Copy link
Author

Thanks, @joemcgill, for your review. 🙏

I'm adding tests for the wp_unique_id_from_values() function. They should be ready before these changes are merged.

@DAreRodz
Copy link
Author

@joemcgill, I just added PHPUnit tests for wp_unique_id_from_values() if you want to take a look.

Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60038
GitHub commit: 8b632c9

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants