-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Layout Support: Replace incremental IDs with hashes #8353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout Support: Replace incremental IDs with hashes #8353
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code and additional tests look good to me.
It would be nice to add some addition test coverage specifically for the new wp_unique_id_from_values()
function, similar to this test class, but I don't see that as a requirement for fixing the bug here.
Thanks, @joemcgill, for your review. 🙏 I'm adding tests for the |
@joemcgill, I just added PHPUnit tests for |
This is a backport PR for WordPress 6.8 that includes the following PHP Gutenberg changes:
Trac ticket: https://core.trac.wordpress.org/ticket/62985
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.