Move puzzle app to a Playground package - #1385
Merged
Merged
Conversation
Collaborator
|
Unit tests failures are intermittent, but the build failure seems legitimate:
|
Collaborator
Author
Yes, I fixed it now. For some reason, I don't get these errors when I run the commands locally so it may take one or two more attempts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
It moves the Playground puzzle app into a Playground package.
What problem is it solving?
It enables us to deploy the puzzle app to the Playground server.
How is the problem addressed?
By creating a new Playground package and updating the code to work with Vite.
Testing Instructions
Note let's address design feedback and improvements in separate PRs to unblock sponsors from updating their blueprints