Skip to content

Move puzzle app to a Playground package - #1385

Merged
adamziel merged 9 commits into
trunkfrom
add/puzzle-app
May 16, 2024
Merged

Move puzzle app to a Playground package#1385
adamziel merged 9 commits into
trunkfrom
add/puzzle-app

Conversation

@bgrgicak

@bgrgicak bgrgicak commented May 14, 2024

Copy link
Copy Markdown
Collaborator

What is this PR doing?

It moves the Playground puzzle app into a Playground package.

What problem is it solving?

It enables us to deploy the puzzle app to the Playground server.

How is the problem addressed?

By creating a new Playground package and updating the code to work with Vite.

Testing Instructions

  • Follow the readme instructions to start a dev server
  • Setup the puzzle API using these instructions
  • Update this line to point to your development API
  • Open the app and click on Build your site
  • Write one of the action keys like multisite on a piece of paper (text should be clear and bold)
  • Scan it
  • Confirm that an action was added
  • Click on Take me to my site
  • Confirm that the site load and the actions were applied

Note let's address design feedback and improvements in separate PRs to unblock sponsors from updating their blueprints

@bgrgicak bgrgicak self-assigned this May 14, 2024
@bgrgicak
bgrgicak marked this pull request as ready for review May 14, 2024 06:08
@bgrgicak
bgrgicak requested a review from a team May 14, 2024 06:09
@adamziel

adamziel commented May 14, 2024

Copy link
Copy Markdown
Collaborator

Unit tests failures are intermittent, but the build failure seems legitimate:

Could not resolve "../node_modules/@wordpress/components/build-style/style.css" from "packages/playground/puzzle/src/index.tsx"

@bgrgicak

Copy link
Copy Markdown
Collaborator Author

Unit tests failures are intermittent, but the build failure seems legitimate:

Yes, I fixed it now. For some reason, I don't get these errors when I run the commands locally so it may take one or two more attempts.

@adamziel
adamziel merged commit 006cb0d into trunk May 16, 2024
@adamziel
adamziel deleted the add/puzzle-app branch May 16, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment