Migrate to NX-based build - #151
Merged
Merged
Conversation
Closed
This was referenced Mar 24, 2023
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets up the correct build pipeline for all parts of Playground and PHP.wasm. This enables a public release of the Playground API npm package!
I've been struggling with this for a while and couldn't understand what's so hard. NX made it apparent – look at this dependency graph!
No wonder it's been almost impossible to set everything up by hand!
Usage
Start with
yarn installShortcuts
To start a copy of
wasm.wordpress.netlocally, runyarn run dev.To build it, run
yarn run build.Fully qualified commands
In reality, these
yarn runcommands are just triggering the underlying project's nxdevandbuildcommands:Here's a few more interesting commands:
NX is the tool Playground needed from the outset
It's ridiculous how many problems this solves:
php-wasm-commonpackage is not imported by anything else thanphp-wasm-webandphp-wasm-nodeNext steps
Related to #148 and #147