Register service worker before spawning the worker thread - #1606
Merged
Conversation
bgrgicak
marked this pull request as ready for review
July 12, 2024 09:13
bgrgicak
commented
Jul 12, 2024
adamziel
reviewed
Jul 12, 2024
adamziel
reviewed
Jul 12, 2024
adamziel
reviewed
Jul 12, 2024
adamziel
reviewed
Jul 12, 2024
adamziel
reviewed
Jul 12, 2024
adamziel
reviewed
Jul 15, 2024
| phpVersion: event.data.startupOptions.phpVersion, | ||
| storage: event.data.startupOptions.storage, | ||
| sapiName: event.data.startupOptions.sapiName, | ||
| phpExtensions: event.data.startupOptions['php-extension'], |
Collaborator
There was a problem hiding this comment.
We need to make these names consistent one day
adamziel
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
For offline support we need to load the service worker as early as possible in the boot process.
Booting early will allow fetch caching to cache more files on the first making the backfill of assets simpler.
Read the full research recap here #1600 (review)
Implementation details
To move
registerServiceWorkerto the start of the boot process we had to generate the scope inbootPlaygroundRemoteand pass it to the PHP worker thread together with other startup options.The service worker had to be registered before spawning the PHP worker thread to ensure WP and PHP assets were cached. But the service worker also depends on the
phpApireturned byspawnPHPWorkerThread.We had to register the service worker first, after that, spawn the PHP worker thread, and then set the
phpApi.This PR also includes changes from #1574 because they allow us to pass the scope.
Testing Instructions (or ideally a Blueprint)