Skip to content

Revert "Offline mode e2e tests" - #1673

Merged
bgrgicak merged 1 commit into
trunkfrom
revert-1648-add/offline-e2e-tests
Aug 8, 2024
Merged

Revert "Offline mode e2e tests"#1673
bgrgicak merged 1 commit into
trunkfrom
revert-1648-add/offline-e2e-tests

Conversation

@bgrgicak

@bgrgicak bgrgicak commented Aug 8, 2024

Copy link
Copy Markdown
Collaborator

These tests area faining in CI, so I'm removing them for now.

@bgrgicak
bgrgicak requested a review from a team as a code owner August 8, 2024 09:13
@bgrgicak bgrgicak self-assigned this Aug 8, 2024
@bgrgicak bgrgicak added the [Type] Bug An existing feature does not function as intended label Aug 8, 2024
@bgrgicak
bgrgicak merged commit 234ee89 into trunk Aug 8, 2024
@bgrgicak
bgrgicak deleted the revert-1648-add/offline-e2e-tests branch August 8, 2024 09:32
bgrgicak added a commit that referenced this pull request Aug 8, 2024
@brandonpayton

Copy link
Copy Markdown
Member

@bgrgicak @adamziel I wonder if we should explore converting e2e tests to Playwright. As an experiment, maybe we could convert one of the simple tests first and then try converting one of the more fragile e2e tests to see whether we get more reliable results.

It's actually something I've meant to try for a while but haven't gotten to it yet.

@adamziel

adamziel commented Aug 9, 2024

Copy link
Copy Markdown
Collaborator

@brandonpayton potentially, although I'd rather add a new Playwright test and, once it works, slowly move them one by one over the course of a few months as a backburner project. Otherwise I worry we might get stuck on porting tests instead of exploring the site manager.

@brandonpayton

Copy link
Copy Markdown
Member

although I'd rather add a new Playwright test and, once it works, slowly move them one by one over the course of a few months as a backburner project. Otherwise I worry we might get stuck on porting tests instead of exploring the site manager.

@adamziel, agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended

3 participants