Avoid errors due to log message formatting - #1726
Merged
Merged
Conversation
brandonpayton
force-pushed
the
fix-logger-message-prop-error
branch
from
September 3, 2024 20:05
96de945 to
601ed46
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Today, we attempt to reassign an error's message property for formatting purposes, but this throws an exception if the error property isn't writable or doesn't have a setter. For example:
These are the assignments that occasionally lead to the error:
https://github.com/WordPress/wordpress-playground/blob/trunk/packages/php-wasm/logger/src/lib/handlers/log-to-console.ts#L9-L11
Since the assignments are just for formatting, it should be OK if we just tolerate the failed assignment using
Reflect.set().Fixes #1514
Implementation details
Use
Reflect.set()to avoid exceptions when the assignment fails.Testing Instructions (or ideally a Blueprint)