JSPI: Pass all unit tests, remove stale PHP builds

[adamziel]

Fixes the JSPI details overlooked in the original JSPI PR (#1867):

• Correctly define the PLAYGROUND_JSPI constant to ensure EM_ASYNC_JS is used in JSPI builds. It wasn't picked up before.
• Provide -sJSPI_IMPORTS during the build to ensure WebAssembly waits for any promises returned by js_open_process and other JavaScript functions.
• Runs the CI tests using Node v23 nightly
• Solves a few small issues – look around the diff for more details

Testing instructions

• CI checks should pass
• All unit tests should pass locally in Node.js v23 nightly:

$ node-v23.0.0-nightly2024100909d10b50dc-darwin-x64/bin/node --experimental-wasm-jspi --experimental-wasm-stack-switching --expose-gc node_modules/nx/bin/nx run php-wasm-node:test

[adamziel]

I got the failures down to the ones below. The test process crashes in CI for some reason so I won't enable the automated JSPI test runner yet.

 ❯ src/test/php-networking.spec.ts  (63 tests | 4 failed) 29341ms
   ❯ src/test/php-networking.spec.ts > PHP 8.3 > cURL > should support HTTPS requests
     → Test timed out in 1000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
   ❯ src/test/php-networking.spec.ts > PHP 8.2 > cURL > should support HTTPS requests
     → Test timed out in 1000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
   ❯ src/test/php-networking.spec.ts > PHP 8.0 > cURL > should support HTTPS requests
     → Test timed out in 1000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
   ❯ src/test/php-networking.spec.ts > PHP 7.1 > cURL > should support HTTPS requests
     → Test timed out in 1000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
stderr | src/test/php.spec.ts > PHP 8.3 > onMessage > should return null when JS message handler throws an error
Failure!
 ✓ src/test/php-request-handler.spec.ts  (470 tests) 90174ms
 ❯ src/test/php-crash.spec.ts  (27 tests | 6 failed) 128512ms
   ❯ src/test/php-crash.spec.ts > PHP 7.0 – process crash > Does not crash due to an unhandled Asyncify error
     → php.run should have thrown an error
   ❯ src/test/php-crash.spec.ts > PHP 7.1 – process crash > Does not crash due to an unhandled Asyncify error
     → php.run should have thrown an error
   ❯ src/test/php-crash.spec.ts > PHP 7.3 – process crash > Does not crash due to an unhandled Asyncify error
     → php.run should have thrown an error
   ❯ src/test/php-crash.spec.ts > PHP 7.4 – process crash > Does not crash due to an unhandled Asyncify error
     → php.run should have thrown an error
   ❯ src/test/php-crash.spec.ts > PHP 8.0 – process crash > Does not crash due to an unhandled Asyncify error
     → php.run should have thrown an error
   ❯ src/test/php-crash.spec.ts > PHP 8.1 – process crash > Does not crash due to an unhandled Asyncify error
     → php.run should have thrown an error

[adamziel]

All JSPI unit tests pass now, although the CI runner crashes so I'll keep it disabled.

[brandonpayton]

@adamziel, I am still getting the asyncify failure-related errors when running via command line.

⎯⎯⎯⎯⎯⎯⎯ Failed Tests 6 ⎯⎯⎯⎯⎯⎯⎯
 FAIL  src/test/php-crash.spec.ts > PHP 7.0 – process crash > Does not crash due to an unhandled Asyncify error 
 FAIL  src/test/php-crash.spec.ts > PHP 7.1 – process crash > Does not crash due to an unhandled Asyncify error 
 FAIL  src/test/php-crash.spec.ts > PHP 7.3 – process crash > Does not crash due to an unhandled Asyncify error 
 FAIL  src/test/php-crash.spec.ts > PHP 7.4 – process crash > Does not crash due to an unhandled Asyncify error 
 FAIL  src/test/php-crash.spec.ts > PHP 8.0 – process crash > Does not crash due to an unhandled Asyncify error 
 FAIL  src/test/php-crash.spec.ts > PHP 8.1 – process crash > Does not crash due to an unhandled Asyncify error 
AssertionError: php.run should have thrown an error 

This is with a local build of nodejs v23, and the command is the same as the one in the test instructions. Any thoughts on this? I'm not sure how that test is supposed to pass when using JSPI.