Fix use of secrets on WP Cloud site - #1909
Merged
Merged
Conversation
brandonpayton
added
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
A previous change to how we serve PHP files on the website broke use of secrets stored with WP Cloud. This PR fixes that.
Implementation details
Because we are using WP cloud persistent data storage early in the request lifecycle (when custom-redirects.php is executed), certain environmental dependencies of persistent storage are not yet defined. This PR forces the definition of those dependencies to give us access to secrets from persistent storage.
Testing Instructions (or ideally a Blueprint)
Manually tested on Playground website.