Add zaerl to GitHub workflows actors - #2041
Merged
Merged
Conversation
Member
|
In the comments of the yml files the usernames are also mentioned which is now outdated. Could you please update the comments, too? Maybe to something more evergreen? |
Collaborator
Author
Sure, let me know what you think about the new comments. A "part of the maintainers' group of users" check is probably usable in the GitHub workflow. That will be evergreen. But I think it's okay this way. We can optimize it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
I need to run this workflow, as well of the future ones.
Implementation details
Add myself to the
ifinstructions of the GitHub workflows.Testing Instructions (or ideally a Blueprint)
Nothing testable. Once merged, I will be able to run https://github.com/WordPress/wordpress-playground/actions/workflows/publish-npm-packages.yml and others.