-
Notifications
You must be signed in to change notification settings - Fork 296
Remove old PR preview HTML files and add redirects to new preview modals #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old PR preview HTML files and add redirects to new preview modals #2081
Conversation
This PR accidentally contained some export exploration work. Will fix. |
6bff7eb
to
0ffb8fa
Compare
Fixed. |
Tests fine after deployment:
|
…view modals" (#2082) Reverts #2081 The change broke PR preview links. The modal does not yet have feature parity with the separate HTML pages. It needs to support all the same user flows and query params before it can replace the existing previewers. Cc @brandonpayton @ajotka
@adamziel, I did not know about those links from the wordpress-develop repo and thought this was simply replacing a UI that required user interaction. I'm sorry for the oversight. And thank you for the revert! |
Instead of getting rid of the standalone pages, maybe we should just change the pages to share lookup logic with the preview modals and otherwise leave the pages as-is. cc @ajotka |
Ah, I see the Playground web app also has |
Motivation for the change, related issues
This PR removes old PR preview pages, adds relevant redirects, and updates old PR preview redirects.
Fixes #1969
Implementation details
In addition to the removals and redirects, this PR:
Testing Instructions (or ideally a Blueprint)
php -l
to ensure there are no syntax errors in custom-redirects-lib.php