Rewrote fileToUint8Array function to be also NodeJS/Deno compatible. - #2117
Merged
adamziel merged 2 commits intoJan 10, 2025
Merged
Conversation
mbuella
force-pushed
the
fileToUint8Array-using-File-arraybuffer
branch
2 times, most recently
from
January 9, 2025 12:38
839d183 to
ab47f97
Compare
mbuella
marked this pull request as ready for review
January 9, 2025 13:04
Collaborator
|
Really good spot and a great fix, thank you! My only ask would be to add either a test or an inline comment to inform the next person to avoid using the FileReader class and why. |
mbuella
force-pushed
the
fileToUint8Array-using-File-arraybuffer
branch
from
January 10, 2025 02:02
ab47f97 to
1937bf7
Compare
Contributor
Author
|
@adamziel thanks for your nice feedback! I have added an inline comment to the updated code to explain why we must avoid using FileReader. |
mbuella
force-pushed
the
fileToUint8Array-using-File-arraybuffer
branch
from
January 10, 2025 09:57
1937bf7 to
34129e7
Compare
Collaborator
|
Thank you @mbuella! The failing test is just a flaky test. Let's merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Performing multipart upload and posting of data currently works on the web (client) side. Doing it on PHP WASM instance running on NodeJS or other server runtimes (except Deno) causes this issue due to FileReader not supported on the runtime:
Implementation details
This PR introduces an alternative to using FileReader in order to determine the
Uint8Arrayvalue for aFileinstance. This is creating a new instance ofUint8Arrayfrom the file's buffer instead.File's arrayBuffer instance method and Uint8Array class are both supported on NodeJS and Deno, and as well as on most recent browsers.Testing Instructions (or ideally a Blueprint)
npm run test