Skip to content

Attempt to fix docs site deployment #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

brandonpayton
Copy link
Member

Motivation for the change, related issues

This PR attempts to fix the following error:

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Implementation details

  • We update actions/upload-pages-artifact from v1 to v3.
  • The v1 version uses actions/upload-artifact@v3.
  • The v3 version uses actions/upload-artifact@v4, which is the latest major version.

Testing Instructions (or ideally a Blueprint)

  • CI

Docs site deployment is already broken. Let's go ahead and merge this and see how doc site deployment runs on trunk.

This attempts to fix the following error:

Error: This request has been automatically failed because it uses a
deprecated version of `actions/upload-artifact: v3`. Learn more:
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

We update actions/upload-pages-artifact from v1 to v3.
The v1 version uses actions/upload-artifact@v3.
The v3 version uses actions/upload-artifact@v4,
which is the latest major version.
@brandonpayton brandonpayton added [Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation labels Feb 28, 2025
@brandonpayton brandonpayton requested review from akirk and a team February 28, 2025 19:53
@brandonpayton brandonpayton self-assigned this Feb 28, 2025
@brandonpayton brandonpayton merged commit 85606ad into trunk Feb 28, 2025
10 checks passed
@brandonpayton brandonpayton deleted the fix-docs-site-deployment branch February 28, 2025 20:35
@github-project-automation github-project-automation bot moved this from Inbox to Done in Playground Board Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation
1 participant