[CLI] Move Blueprints v2 to Playground CLI package - #2364
Merged
Conversation
adamziel
added
[Type] Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Moves Blueprints v2
.pharfile and the TypeScript module into the@wp-playground/clipackage and brushes up its logic.This PR only moves dead code around. However, it also changes the dependency graph of the project and affects the computed package.json files, as in
@wp-playground/clinow depends onfs-ext. For that reason, there's also a change in the build machinery.Also,
v2.spec.tsuncovered a piping issue where polling after closing the pipe caused a fatal error. Therefore, this PR adds an FS.isClosed() check.A part of #2281
Testing plan
CI