[Asyncify] Fix fix-asyncify command - #3509
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Restores the missing NX target required by the npm run fix-asyncify workflow by reintroducing an aggregate asyncify test target.
Changes:
- Re-added the
test-php-asyncify-allNX target as anx:noopaggregator. - Configured it to depend on all asyncify test group targets so the workflow can run end-to-end again.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
brandonpayton
approved these changes
Apr 24, 2026
brandonpayton
left a comment
brandonpayton
left a comment
Member
There was a problem hiding this comment.
Looks good, and the target is no longer missing. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Related to this issue
The
npm run fix-asyncifycommand was broken because thetest-php-asyncify-allNX target was removed frompackages/php-wasm/node/project.jsonin a previous pull request. Therebuild-while-asyncify-functions-missing.mjsscript depends on this target to run all asyncify test groups, so without it, thefix-asyncifyworkflow fails.Implementation details
Re-added the
test-php-asyncify-alltarget topackages/php-wasm/node/project.json. It is anx:noopexecutor that depends on all asyncify test group targets, matching the original definition that was accidentally removed.Testing Instructions (or ideally a Blueprint)
Run
npm run fix-asyncifyand verify it no longer errors out with a missing target.