Skip to content

Wait for personal-wp address bar readiness - #3593

Closed
ashfame wants to merge 1 commit into
trunkfrom
fix/personal-wp-address-bar-readiness
Closed

Wait for personal-wp address bar readiness#3593
ashfame wants to merge 1 commit into
trunkfrom
fix/personal-wp-address-bar-readiness

Conversation

@ashfame

@ashfame ashfame commented May 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Make the personal-wp Playwright page helper wait for the toolbar address bar to contain a WordPress path after the nested WordPress iframe body has loaded.
  • This avoids the flaky race where the address bar update handler can run before BrowserChrome has re-rendered with live clientInfo.
  • Scope is limited to personal-wp Playwright readiness. Database/MySQL fixes and PR Fix saved SQLite site boot #3588 saved-site SQLite work are intentionally out of scope.

Validation

  • PASS: npm exec nx lint playground-personal-wp
  • PASS: npm exec nx typecheck playground-personal-wp
  • BLOCKED LOCALLY: npm exec nx run playground-personal-wp:e2e:playwright -- packages/playground/personal-wp/playwright/e2e/ui.spec.ts
    • The default Playwright web server could not start because this environment does not have a php binary for playground-php-cors-proxy:start.
    • Retried against directly started Vite servers with CORS_PROXY_URL=; Playwright reached Chromium launch, but Chromium could not start because libatk-1.0.so.0 is missing.
    • No Playwright assertions executed locally. CI should perform the actual e2e validation.
@akirk

akirk commented May 6, 2026

Copy link
Copy Markdown
Member

@ashfame I'm removing the addressbar in personal-wp im #3601, I guess this could then be just closed.

@ashfame

ashfame commented May 6, 2026

Copy link
Copy Markdown
Member Author

@akirk I think we would need to change the approach but still need a fix for the flakiness.

@akirk

akirk commented Jun 30, 2026

Copy link
Copy Markdown
Member

The address bar has been removed, there is no this.addressBar()

@akirk akirk closed this Jun 30, 2026
@ashfame
ashfame deleted the fix/personal-wp-address-bar-readiness branch July 6, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants