Fix PHP-WASM node rebuild Docker context - #3608
Merged
mho22 merged 2 commits intoMay 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Re-includes node-builds/ in the packages/php-wasm Docker build context so the existing node rebuild path can successfully COPY build artifacts into the image (fixing #3607).
Changes:
- Un-ignore
node-builds/and its contents inpackages/php-wasm/.dockerignoreso Docker can include them in the build context.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -7,3 +7,5 @@ | |||
| !compile-extension/docker/Dockerfile.ext | |||
| !compile-extension/scripts/ | |||
| !compile-extension/scripts/build-in-docker.sh | |||
Contributor
Author
There was a problem hiding this comment.
I thought about this, and it does make sense. But I'm leaving it open until someone else sees this.
Collaborator
There was a problem hiding this comment.
I don't think the comment is needed.
mho22
requested changes
May 7, 2026
| @@ -7,3 +7,5 @@ | |||
| !compile-extension/docker/Dockerfile.ext | |||
| !compile-extension/scripts/ | |||
| !compile-extension/scripts/build-in-docker.sh | |||
Collaborator
There was a problem hiding this comment.
I don't think the comment is needed.
Contributor
Author
|
@mho22 |
mho22
approved these changes
May 7, 2026
chubes4
force-pushed
the
fix/php-wasm-node-builds-dockerignore
branch
from
May 7, 2026 23:15
a0b1747 to
394b8b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Re-include
node-builds/inpackages/php-wasm/.dockerignoreso the existing PHP-WASM node rebuild path can copy extension side modules into the Docker image.Fixes #3607.
Why?
packages/php-wasm/compile/php/Dockerfiledoes:COPY ./${EMSCRIPTEN_ENVIRONMENT}-builds/ /root/${EMSCRIPTEN_ENVIRONMENT}-buildsFor node builds, that requires
node-builds/to be present in the Docker build context. The current.dockerignoreexcludes it, causing the existing node rebuild command to fail atCOPY ./node-builds/ /root/node-builds.Testing Instructions
Run:
Expected: the Docker build should pass the
COPY ./node-builds/ /root/node-buildsstep and complete the PHP-WASM image/output extraction.Testing performed
.dockerignorefix locally.node packages/php-wasm/compile/build.js --PLATFORM=node --PHP_VERSION=8.3 --WITH_JSPI=yesfrom a clean PR worktree using existing installed dependencies../node-builds/, processed the extension side modules, built the image, and extracted the JSPI output.AI assistance