Expose SQLite auto-extension symbols to JS ABI - #3641
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds SQLite auto-extension symbols to the PHP wasm JS ABI export list so external side modules can resolve them via the dynamic linker.
Changes:
- Add
_sqlite3_auto_extensionto exported functions list - Add
_sqlite3_cancel_auto_extensionto exported functions list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamziel
added a commit
that referenced
this pull request
May 14, 2026
…3642) This updates the generated Node PHP 8.4 JSPI wasm artifact after #3641 so the npm package includes the newly exported SQLite auto-extension symbols. The CLI side module imports sqlite3_auto_extension and sqlite3_cancel_auto_extension when loading php-extension side modules; without these exports @wp-playground/cli fails with `resolved is not a function`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
_sqlite3_auto_extensionand_sqlite3_cancel_auto_extensionto the PHP wasm JS ABI export list.Why
@php-wasm/node-8-4@3.1.31exports these symbols from the wasm binary, but the generated JS runtime does not expose them to the dynamic linker symbol map. External side modules that importsqlite3_auto_extensionfail during startup withresolved is not a function.Testing
wasm-objdumpsees the wasm exports in@php-wasm/node-8-4@3.1.31.