[Website] Delay autosave nudge until dismissal can save the new Playground - #3823
Merged
Conversation
adamziel
marked this pull request as ready for review
June 24, 2026 08:25
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts the restore-autosave nudge flow so users can’t dismiss it (“No, thanks”) before the fresh temporary Playground has fully booted, avoiding autosave attempts without an active client.
Changes:
- Capture the
temporarySiteSlugfromcreateNewTemporarySite()and store it inautosaveNudgestate. - Use the captured
temporarySiteSlugwhen callingautosaveTemporarySite()on nudge dismissal. - Add a Playwright regression test covering immediate dismissal of the restore nudge after reloading a setup URL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/playground/website/src/components/ensure-playground-site/ensure-playground-site-is-selected.tsx | Gate nudge rendering until a temporary site is created; autosave the correct site slug on dismissal. |
| packages/playground/website/playwright/e2e/website-ui.spec.ts | Add Chromium-only regression test for immediate restore-nudge dismissal behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamziel
force-pushed
the
autosave-restore-nudge-boot
branch
from
June 24, 2026 08:34
b8d72d0 to
9474f97
Compare
adamziel
force-pushed
the
autosave-restore-nudge-boot
branch
9 times, most recently
from
July 7, 2026 18:44
ce0d8bb to
ad16e0b
Compare
adamziel
force-pushed
the
autosave-restore-nudge-boot
branch
4 times, most recently
from
July 7, 2026 20:31
e4044dd to
bbabfcd
Compare
adamziel
force-pushed
the
autosave-restore-nudge-boot
branch
2 times, most recently
from
July 7, 2026 22:24
5c757bf to
c32a3d9
Compare
adamziel
force-pushed
the
autosave-restore-nudge-boot
branch
from
July 7, 2026 23:08
c32a3d9 to
01d331e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Delays the autosave restore nudge until the fresh matching Playground can be saved, so
No, thanksno longer runs before the new Playground has an active client.The site-selection flow and popover actions are unchanged. This PR only gates rendering of the nudge until the active site:
PlaygroundClient;Rationale
When a matching autosave exists, the restore nudge could appear before the fresh temporary Playground had an active
PlaygroundClient. If the user clickedNo, thanksduring that window,autosaveTemporarySite()tried to save beforepersistTemporarySite()could find a client.That produced:
and left the user at the same restore prompt.
Waiting to show the nudge keeps the fix local to the popover display and avoids changing the app’s site-selection flow.
Testing instructions