[Tests] Fix legacy WP plugin activation selector - #3825
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes flakiness in the legacy WordPress boot test by ensuring the plugin activation step targets the Hello Dolly activation link (instead of clicking the first “Activate” link, which can be Akismet).
Changes:
- Replaces the “first Activate link” fallback with a Hello Dolly–specific activation selector.
- Waits for the Hello Dolly activation link to render before attempting activation.
- Preserves the existing skip behavior when no suitable activation link is found.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bgrgicak
marked this pull request as draft
June 24, 2026 09:20
bgrgicak
marked this pull request as ready for review
June 24, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the legacy WordPress boot test plugin activation phase so it waits for and clicks the Hello Dolly activation link specifically.
Motivation for the change, related issues
The
test-legacy-wp-version-bootCI job can fail when the plugins page renders Akismet's activation link before Hello Dolly. The old fallback clicked the firstActivatelink, which can land on Akismet's setup screen and then time out while waiting for the Hello Dolly-style activation indicators.Related failing job: https://github.com/WordPress/wordpress-playground/actions/runs/28081251039/job/83136494931?pr=3824
Implementation details
Activatefallback.a[href*="action=activate"][href*="hello.php"]before clicking.SKIP/no activate link foundstatus when no activation link is available.Testing Instructions