Skip to content

[Blueprints] Fix package typecheck target - #3859

Merged
adamziel merged 1 commit into
trunkfrom
fix/blueprints-typecheck-target
Jul 1, 2026
Merged

[Blueprints] Fix package typecheck target#3859
adamziel merged 1 commit into
trunkfrom
fix/blueprints-typecheck-target

Conversation

@adamziel

@adamziel adamziel commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

What it does

Makes playground-blueprints:typecheck typecheck the Blueprints package instead of packages/playground/remote.

Rationale

The target currently runs:

tsc -p packages/playground/remote/tsconfig.spec.json --noEmit
tsc -p packages/playground/remote/tsconfig.lib.json --noEmit

That means Blueprints changes can pass playground-blueprints:typecheck without checking Blueprints sources or specs.

Implementation

Points the target at:

tsc -p packages/playground/blueprints/tsconfig.spec.json --noEmit
tsc -p packages/playground/blueprints/tsconfig.lib.json --noEmit

The corrected spec typecheck exposed two deprecated-input tests that intentionally omit pluginData / themeData. Those tests now use @ts-expect-error because they verify runtime support for deprecated pluginZipFile and themeZipFile.

Testing instructions

npm run format:uncommitted
npm exec nx run playground-blueprints:typecheck
npm exec nx run playground-blueprints:lint
npm exec nx run playground-blueprints:test:vite -- --testFiles=packages/playground/blueprints/src/tests/steps/install-plugin.spec.ts
npm exec nx run playground-blueprints:test:vite -- --testFiles=packages/playground/blueprints/src/tests/steps/install-theme.spec.ts
git diff --check
@adamziel
adamziel marked this pull request as ready for review July 1, 2026 23:01
@adamziel
adamziel requested review from a team, ashfame and Copilot July 1, 2026 23:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes the playground-blueprints:typecheck Nx target so it checks the Blueprints package (not packages/playground/remote) and updates a couple of tests to account for deprecated-but-supported inputs now being caught by the corrected typecheck.

Changes:

  • Update playground-blueprints:typecheck to run tsc against Blueprints’ tsconfig.spec.json and tsconfig.lib.json.
  • Add @ts-expect-error annotations in two tests that intentionally use deprecated pluginZipFile / themeZipFile.
  • Minor test formatting tweaks to toThrow(...) expectations.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/playground/blueprints/project.json Points the Nx typecheck commands at the correct Blueprints tsconfig files.
packages/playground/blueprints/src/tests/steps/install-plugin.spec.ts Adds a TypeScript expectation marker for deprecated input use in a runtime-compat test.
packages/playground/blueprints/src/tests/steps/install-theme.spec.ts Adds a TypeScript expectation marker for deprecated input use and tidies toThrow formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +365 to 367
// @ts-expect-error themeZipFile is deprecated but still supported at runtime.
await installTheme(php, {
themeZipFile: new File([zip], unexpectedZipFileName),
Comment on lines +374 to 376
// @ts-expect-error pluginZipFile is deprecated but still supported at runtime.
await installPlugin(php, {
pluginZipFile: await zipFiles(php, zipFileName, {
Comment on lines +106 to +107
"tsc -p packages/playground/blueprints/tsconfig.spec.json --noEmit",
"tsc -p packages/playground/blueprints/tsconfig.lib.json --noEmit"
@adamziel
adamziel merged commit a578a8b into trunk Jul 1, 2026
153 of 155 checks passed
@adamziel
adamziel deleted the fix/blueprints-typecheck-target branch July 1, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment