[Blueprints] Fix package typecheck target - #3859
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes the playground-blueprints:typecheck Nx target so it checks the Blueprints package (not packages/playground/remote) and updates a couple of tests to account for deprecated-but-supported inputs now being caught by the corrected typecheck.
Changes:
- Update
playground-blueprints:typecheckto runtscagainst Blueprints’tsconfig.spec.jsonandtsconfig.lib.json. - Add
@ts-expect-errorannotations in two tests that intentionally use deprecatedpluginZipFile/themeZipFile. - Minor test formatting tweaks to
toThrow(...)expectations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/playground/blueprints/project.json | Points the Nx typecheck commands at the correct Blueprints tsconfig files. |
| packages/playground/blueprints/src/tests/steps/install-plugin.spec.ts | Adds a TypeScript expectation marker for deprecated input use in a runtime-compat test. |
| packages/playground/blueprints/src/tests/steps/install-theme.spec.ts | Adds a TypeScript expectation marker for deprecated input use and tidies toThrow formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+365
to
367
| // @ts-expect-error themeZipFile is deprecated but still supported at runtime. | ||
| await installTheme(php, { | ||
| themeZipFile: new File([zip], unexpectedZipFileName), |
Comment on lines
+374
to
376
| // @ts-expect-error pluginZipFile is deprecated but still supported at runtime. | ||
| await installPlugin(php, { | ||
| pluginZipFile: await zipFiles(php, zipFileName, { |
Comment on lines
+106
to
+107
| "tsc -p packages/playground/blueprints/tsconfig.spec.json --noEmit", | ||
| "tsc -p packages/playground/blueprints/tsconfig.lib.json --noEmit" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Makes
playground-blueprints:typechecktypecheck the Blueprints package instead ofpackages/playground/remote.Rationale
The target currently runs:
That means Blueprints changes can pass
playground-blueprints:typecheckwithout checking Blueprints sources or specs.Implementation
Points the target at:
The corrected spec typecheck exposed two deprecated-input tests that intentionally omit
pluginData/themeData. Those tests now use@ts-expect-errorbecause they verify runtime support for deprecatedpluginZipFileandthemeZipFile.Testing instructions