[Blueprints] Type Blueprint v2 WXR author maps - #3863
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Blueprint v2 WXR author-map TypeScript declarations to allow real (non-literal) username mappings, and adds a type-level test to prevent regressions.
Changes:
- Fix
RemoteUsername/LocalUsernametype aliases from the literal'string'tostring. - Add a declaration/typecheck test covering arbitrary
authorsMapkeys/values for WXR imports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/playground/blueprints/src/lib/v2/wep-1-blueprint-v2-schema/appendix-A-blueprint-v2-schema.ts | Corrects WXR author-map username aliases to be real strings. |
| packages/playground/blueprints/src/tests/v2/blueprint-v2-declaration.spec.ts | Adds a type regression test ensuring authorsMap accepts arbitrary usernames. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes the Blueprint v2 WXR author-map declaration types.
RemoteUsernameandLocalUsernamewere typed as the literal value'string', which madeauthorsMaponly accept that exact value. This changes both aliases tostringso real usernames can be mapped.Why?
Blueprint v2 WXR imports can map remote authors to local users. TypeScript consumers should be able to write real mappings such as:
This is type-only. It does not change runtime behavior.
Testing
npm exec nx run playground-blueprints:typechecknpm exec nx run playground-blueprints:lintnpm exec nx run playground-blueprints:test:vite -- --testFiles=packages/playground/blueprints/src/tests/v2/blueprint-v2-declaration.spec.tsgit diff --checkPart of #2592.