Skip to content

[Blueprints] Test Blueprint v2 runtime defaults - #3888

Merged
adamziel merged 2 commits into
trunkfrom
add-v2-runtime-config-default-tests
Jul 3, 2026
Merged

[Blueprints] Test Blueprint v2 runtime defaults#3888
adamziel merged 2 commits into
trunkfrom
add-v2-runtime-config-default-tests

Conversation

@adamziel

@adamziel adamziel commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

What?

Adds focused tests for the runtime configuration currently returned by resolveRuntimeConfiguration() for Blueprint v2 declarations.

The tests cover both direct Blueprint v2 declaration objects and bundled blueprint.json declarations.

Why?

The next stack entries start resolving concrete Blueprint v2 runtime fields. This PR locks in the current default behavior first so follow-up PRs can show one behavior change at a time.

Testing

  • npm run format:uncommitted
  • npm exec nx run playground-blueprints:test:vite -- --testFiles=packages/playground/blueprints/src/tests/v2/resolve-runtime-configuration.spec.ts
  • npm exec nx run playground-blueprints:typecheck
  • npm exec nx run playground-blueprints:lint
  • git diff --check

Part of #2592.

@adamziel
adamziel requested review from a team, ashfame and Copilot and removed request for Copilot July 3, 2026 12:05
@adamziel
adamziel requested a review from Copilot July 3, 2026 12:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds Vitest coverage for resolveRuntimeConfiguration() defaults when given Blueprint v2 declarations (both direct objects and bundled blueprint.json).

Changes:

  • Introduces a new spec covering the default runtime configuration fields for Blueprint v2.
  • Adds a small in-test bundle helper to emulate blueprint.json reads.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/playground/blueprints/src/tests/v2/resolve-runtime-configuration.spec.ts Outdated
Comment thread packages/playground/blueprints/src/tests/v2/resolve-runtime-configuration.spec.ts Outdated
@adamziel
adamziel merged commit b52c0a2 into trunk Jul 3, 2026
150 of 153 checks passed
@adamziel
adamziel deleted the add-v2-runtime-config-default-tests branch July 3, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment