[Blueprints] Resolve exact Blueprint v2 PHP versions - #3890
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Blueprint v2 PHP version string resolution so phpVersion values like 8.2 and next flow into RuntimeConfiguration.phpVersion, with validation against supported PHP versions.
Changes:
- Resolve Blueprint v2
phpVersionwhen it’s a supported exact string (e.g.8.2,next) - Throw a clear error for unsupported string versions
- Add unit tests for supported/unsupported string cases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/playground/blueprints/src/lib/resolve-runtime-configuration.ts | Adds v2 PHP version resolution/validation via resolveV2PHPVersion() |
| packages/playground/blueprints/src/tests/v2/resolve-runtime-configuration.spec.ts | Adds tests covering accepted versions and rejection of unsupported strings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamziel
force-pushed
the
resolve-v2-runtime-network-access
branch
from
July 3, 2026 12:17
bff45bd to
d6374ae
Compare
adamziel
force-pushed
the
resolve-v2-runtime-php-version
branch
from
July 3, 2026 12:18
3e40dea to
6c30491
Compare
adamziel
force-pushed
the
resolve-v2-runtime-network-access
branch
from
July 3, 2026 13:18
d6374ae to
a749a08
Compare
adamziel
force-pushed
the
resolve-v2-runtime-php-version
branch
from
July 3, 2026 13:19
6c30491 to
1c9047d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Resolves exact Blueprint v2
phpVersionstrings intoRuntimeConfiguration.phpVersion.Supported examples include concrete bundled versions like
8.2and thenextpseudo-version. Constraint-object handling remains unchanged and is left for a later PR.Why?
This lets Playground choose the requested PHP runtime for the simple, already-supported Blueprint v2 schema shape without pulling in version-constraint resolution yet.
Testing
npm run format:uncommittednpm exec nx run playground-blueprints:test:vite -- --testFiles=packages/playground/blueprints/src/tests/v2/resolve-runtime-configuration.spec.tsnpm exec nx run playground-blueprints:typechecknpm exec nx run playground-blueprints:lintgit diff --checkPart of #2592.