[E2E] Use routed CURLFile upload fixture - #3893
Merged
Merged
Conversation
adamziel
requested review from
a team,
Copilot and
mho22
and removed request for
Copilot
July 3, 2026 12:33
adamziel
force-pushed
the
adamziel/fix-flaky-e2e
branch
from
July 3, 2026 12:48
f2f6db8 to
dec0546
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the CURLFile e2e test to remove reliance on httpbin.org by using a local upload-echo fixture served via the existing CORS proxy dev server, reducing CI flakiness.
Changes:
- Added a local upload endpoint URL (based on
CORS_PROXY_PORT) for thecurl_exec()upload test. - Reduced the uploaded payload size and updated test documentation to reflect the new local-only behavior.
- Introduced a PHP fixture that echoes uploaded file contents as JSON.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/playground/website/playwright/e2e/blueprints.spec.ts | Switches the e2e upload test from httpbin to a local fixture endpoint and adjusts payload/docs. |
| packages/playground/php-cors-proxy/tests/fixtures/curlfile-upload-test.php | Adds a local PHP echo endpoint that returns uploaded file contents for the e2e test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
+20
| foreach ($_FILES as $name => $file) { | ||
| $files[$name] = file_get_contents($file['tmp_name']); | ||
| } |
| $files[$name] = file_get_contents($file['tmp_name']); | ||
| } | ||
|
|
||
| echo json_encode(['files' => $files]); |
Comment on lines
+457
to
+459
| const uploadEndpoint = `http://127.0.0.1:${ | ||
| process.env.CORS_PROXY_PORT ?? '5263' | ||
| }/tests/fixtures/curlfile-upload-test.php`; |
adamziel
force-pushed
the
adamziel/fix-flaky-e2e
branch
2 times, most recently
from
July 3, 2026 13:22
6a7f54d to
1f4e2d2
Compare
adamziel
changed the title
adamziel
force-pushed
the
adamziel/fix-flaky-e2e
branch
2 times, most recently
from
July 3, 2026 13:40
512f8c8 to
1eb5c17
Compare
adamziel
force-pushed
the
adamziel/fix-flaky-e2e
branch
from
July 3, 2026 13:58
1eb5c17 to
f0dd663
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaces the flaky
CURLFile uploads via curl_exec() should worktest dependency onhttps://httpbin.org/postwith a Playwright-routed upload endpoint.The routed endpoint keeps the test in-process and still verifies that
curl_exec()succeeds with aCURLFilemultipart upload request, without depending on a third-party echo service.Why?
The failed CI log showed the request reached
httpbin.orgthrough the local CORS proxy, buthttpbin.orgreturned503 Service Temporarily Unavailable:That makes the test fail when the external service is down or rate-limited, even though Playground's CURLFile upload path is working.
Testing Instructions
git diff --check