[Blueprints] Resolve recommended Blueprint v2 PHP versions - #3895
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates Blueprint v2 runtime resolution to honor an explicit phpVersion.recommended when phpVersion is provided as a constraint object, while preserving the existing default behavior when no recommended version is provided.
Changes:
- Resolve
RuntimeConfiguration.phpVersionfromphpVersion.recommendedfor Blueprint v2 constraint objects. - Refactor PHP version parsing/validation into a shared helper.
- Update/add tests for recommended-vs-default constraint behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/playground/blueprints/src/lib/resolve-runtime-configuration.ts | Adds support for phpVersion.recommended and factors string validation into a helper. |
| packages/playground/blueprints/src/tests/v2/resolve-runtime-configuration.spec.ts | Adjusts tests to cover recommended resolution and default fallback. |
Comments suppressed due to low confidence (1)
packages/playground/blueprints/src/tests/v2/resolve-runtime-configuration.spec.ts:1
- The test expects
phpVersion: '8.2', but the provided constraint object does not include arecommendedfield. With the new resolver logic, this will fall back toRecommendedPHPVersion, so this assertion should fail. Addrecommended: '8.2'to the constraint object (or change the expectation toRecommendedPHPVersionif the intent is to validate the default behavior).
import { StreamedFile } from '@php-wasm/stream-compression';
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }); | ||
| }); | ||
|
|
||
| it('uses the default PHP version for constraints without a recommended version', async () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Uses
phpVersion.recommendedfrom Blueprint v2 PHP constraint objects when resolvingRuntimeConfiguration.phpVersion. Constraints without a recommended version keep the current default behavior.Why
Blueprint v2 already lets callers express a preferred PHP version inside a constraint object. This lets Playground honor that explicit runtime choice without adding full constraint solving yet.
Testing
npm run format:uncommittednpm exec nx run playground-blueprints:test:vite -- --testFiles=packages/playground/blueprints/src/tests/v2/resolve-runtime-configuration.spec.tsnpm exec nx run playground-blueprints:typechecknpm exec nx run playground-blueprints:lintgit diff --checkPart of #2592.