Skip to content

[Blueprints] Resolve Blueprint v2 PHP version constraints - #3897

Merged
adamziel merged 1 commit into
trunkfrom
resolve-v2-runtime-php-constraints
Jul 3, 2026
Merged

[Blueprints] Resolve Blueprint v2 PHP version constraints#3897
adamziel merged 1 commit into
trunkfrom
resolve-v2-runtime-php-constraints

Conversation

@adamziel

@adamziel adamziel commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

What

When a Blueprint v2 PHP constraint object has no recommended version, resolves a concrete PHP runtime from min/max bounds:

  • keeps RecommendedPHPVersion when it satisfies the bounds
  • otherwise selects the highest concrete supported PHP version that satisfies them

Why

This makes constraint objects meaningful even when they omit recommended, while still avoiding full validation/error behavior for unsatisfiable constraints in this slice.

Testing

  • npm run format:uncommitted
  • npm exec nx run playground-blueprints:test:vite -- --testFiles=packages/playground/blueprints/src/tests/v2/resolve-runtime-configuration.spec.ts
  • npm exec nx run playground-blueprints:typecheck
  • npm exec nx run playground-blueprints:lint
  • git diff --check

Part of #2592.

@adamziel
adamziel force-pushed the resolve-v2-runtime-php-latest branch from bc81c80 to 9199539 Compare July 3, 2026 13:48
Base automatically changed from resolve-v2-runtime-php-latest to trunk July 3, 2026 13:48
@adamziel
adamziel requested review from a team and ashfame July 3, 2026 13:48
@adamziel
adamziel force-pushed the resolve-v2-runtime-php-constraints branch from c9926f1 to 5a60f85 Compare July 3, 2026 13:48
@adamziel
adamziel merged commit b247b60 into trunk Jul 3, 2026
51 checks passed
@adamziel
adamziel deleted the resolve-v2-runtime-php-constraints branch July 3, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment