[Blueprints] Reject unsatisfied Blueprint v2 PHP constraints - #3898
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds explicit rejection (with a clear error) when a Blueprint v2 phpVersion constraint object cannot be satisfied by any supported Playground PHP runtime, preventing silent fallback to the recommended version.
Changes:
- Throw an error when constraint-object PHP version resolution fails instead of falling back to the recommended PHP version.
- Add a regression test ensuring unsatisfiable
min/maxconstraints are rejected.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/playground/blueprints/src/lib/resolve-runtime-configuration.ts | Throws when Blueprint v2 PHP constraint objects can’t be resolved to a supported PHP version. |
| packages/playground/blueprints/src/tests/v2/resolve-runtime-configuration.spec.ts | Adds a test asserting unsatisfiable PHP constraints reject with a helpful error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamziel
force-pushed
the
reject-v2-runtime-php-unsatisfied
branch
from
July 3, 2026 14:01
4de7b06 to
c0f452b
Compare
adamziel
added a commit
that referenced
this pull request
Jul 3, 2026
## What Adds `compileBlueprintForExecution()` as a small v1-only facade that returns the compiled Blueprint together with the normalized declaration and `run` function. ## Why Consumers that need to support multiple Blueprint execution paths need an entrypoint shaped around execution, not the legacy v1-only `compileBlueprint()` alias. This introduces the public shape without adding Blueprint v2 compiler behavior yet. Replaces #3899, which was closed when the lower stacked base branch was deleted after #3898 merged. ## Testing - `npm run format:uncommitted` - `npm exec nx run playground-blueprints:test:vite -- --testFiles=packages/playground/blueprints/src/tests/compile.spec.ts` - `npm exec nx run playground-blueprints:typecheck` - `npm exec nx run playground-blueprints:lint` - `git diff --check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Throws a clear error when a Blueprint v2 PHP constraint object cannot match any supported Playground PHP runtime.
Why
After resolving
min/maxconstraints, falling back to the default PHP version would hide invalid or unsatisfiable constraints. This keeps runtime resolution honest before booting WordPress.Testing
npm run format:uncommittednpm exec nx run playground-blueprints:test:vite -- --testFiles=packages/playground/blueprints/src/tests/v2/resolve-runtime-configuration.spec.tsnpm exec nx run playground-blueprints:typechecknpm exec nx run playground-blueprints:lintgit diff --checkPart of #2592.