[Blueprints] Support v2 in the browser without ?experimental-blueprints-v2-runner=yes - #3997
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Routes web Blueprint execution strictly based on Blueprint schema version (declaration/bundle), removing the startPlaygroundWeb() v2 opt-in and updating website/personal-wp URL handling + tests accordingly.
Changes:
- Removed
experimentalBlueprintsV2RunnerfromStartPlaygroundOptionsand stopped reading?experimental-blueprints-v2-runner=yesin website and personal-wp boot flows. - Updated v2 routing logic to rely only on Blueprint declaration/bundle version detection.
- Updated Playwright + unit tests to validate the version-based routing and legacy URL stripping.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/playground/website/src/lib/state/redux/boot-site-client.ts | Removes query-param-based v2 opt-in when booting the website client. |
| packages/playground/website/playwright/e2e/blueprints.spec.ts | Updates website e2e to rely on version: 2 routing without an opt-in query param. |
| packages/playground/remote/src/lib/playground-worker-endpoint.ts | Marks worker opt-in flag as deprecated/no-op in WorkerBootOptions docs. |
| packages/playground/personal-wp/src/lib/state/url/router.ts | Keeps retired query key solely for stripping legacy URLs. |
| packages/playground/personal-wp/src/lib/state/url/landing-page.spec.ts | Adds test coverage for stripping retired v2 opt-in from legacy URLs. |
| packages/playground/personal-wp/src/lib/state/redux/boot-site-client.ts | Removes query-param-based v2 opt-in when booting the personal-wp client. |
| packages/playground/client/src/index.ts | Removes opt-in option and routes v2 strictly by Blueprint schema version/bundle reflection. |
| packages/playground/client/src/index.spec.ts | Adds unit test ensuring v2 bundles are routed through the v2 handler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Blueprints already have a version field. This makes it the only switch that selects the web runner.
startPlaygroundWeb()routesversion: 2declarations and bundles to the v2 handler. Website and Personal WP no longer inspect?experimental-blueprints-v2-runner=yes, and the website smoke test boots the v2 declaration without it.Breaking TypeScript change:
experimentalBlueprintsV2Runneris gone fromStartPlaygroundOptions. Callers must remove it and putversion: 2in the Blueprint. The low-levelWorkerBootOptionsmember remains as a deprecated no-op until the old remote v2 worker is deleted.Rationale
The experimental flag duplicated information already present in the Blueprint. Worse, it could force a v1 or empty Blueprint through the v2 handler. Two switches for one decision means they can disagree.
The existing website test also passed the flag, so it never tested normal v2 routing. It does now.
Bundles still use
BlueprintReflectionto read their declaration version.blueprints-runner=v1is deliberately unchanged: the client-side v2 handler compiles and executes the plan against the normal remote API. Personal WP keeps the retired query key only to strip it from old URLs.Testing instructions