[Blueprints] Remove v2 experimental compatibility aliases - #4007
Merged
Conversation
This was referenced Jul 10, 2026
adamziel
force-pushed
the
blueprint-v2-analytics-events
branch
from
July 10, 2026 23:55
d066c65 to
f44cb52
Compare
adamziel
force-pushed
the
blueprint-v2-remove-experimental-aliases
branch
from
July 10, 2026 23:55
f8966a3 to
f43f1c1
Compare
adamziel
force-pushed
the
blueprint-v2-analytics-events
branch
from
July 11, 2026 00:51
f44cb52 to
b30be8c
Compare
adamziel
force-pushed
the
blueprint-v2-remove-experimental-aliases
branch
from
July 11, 2026 10:11
f43f1c1 to
b11910f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the retired Blueprint v2 experimental compatibility aliases across CLI, worker boot options, and Personal WP URL handling now that v2 declarations automatically select the native TypeScript path.
Changes:
- Drops the hidden CLI
--experimental-blueprints-v2-runnerflag and removes related handler-selection/translation logic. - Removes the no-op
experimentalBlueprintsV2Runnerworker boot option and stops stripping the retired query param from Personal WP URLs. - Updates/adjusts tests and auto-mount theme activation step emission to always use the v1-shaped step.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/playground/remote/src/lib/playground-worker-endpoint.ts | Removes deprecated/no-op worker boot option. |
| packages/playground/personal-wp/src/lib/state/url/router.ts | Stops stripping the retired v2 opt-in query parameter from URLs. |
| packages/playground/personal-wp/src/lib/state/url/landing-page.spec.ts | Updates landing-page behavior expectation for retired query param. |
| packages/playground/cli/tests/run-cli.spec.ts | Changes CLI test to assert the retired flag is rejected. |
| packages/playground/cli/tests/mounts.spec.ts | Removes v2-runner-specific auto-mount step-shape test. |
| packages/playground/cli/src/run-cli.ts | Removes CLI flag + translation logic and removes handler-selection alias branch. |
| packages/playground/cli/src/mounts.ts | Always emits v1-shaped activateTheme step (themeFolderName). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the retired Blueprint v2 opt-in aliases now that v2 declarations select the native TypeScript path automatically.
--experimental-blueprints-v2-runnerflag and its v1-option translations are gone.WorkerBootOptions.experimentalBlueprintsV2Runner, which was already a no-op, is gone.Breaking change
Callers still passing
--experimental-blueprints-v2-runnermust remove it. Use a v2 declaration for automatic selection, or use--modeto choosecreate-new-site,apply-to-existing-site, ormount-only. Use--allow=follow-symlinksand--allow=read-local-fsfor the capabilities the alias used to infer from old flags.Code passing
experimentalBlueprintsV2Runnerin worker boot options must remove that property. It has had no effect since handler selection moved before worker boot.Testing
npm exec -- nx run-many -t typecheck -p playground-cli playground-personal-wp playground-remote --parallel=3npm exec -- nx run-many -t lint -p playground-cli playground-personal-wp playground-remote --parallel=3npm exec -- nx run playground-cli:test-playground-cli --testFiles=mounts.spec.tsnpx vitest run --config packages/playground/cli/vite.config.ts packages/playground/cli/tests/run-cli.spec.ts -t "should reject the retired experimental v2 flag"npm exec -- nx test playground-personal-wp --testFile=landing-page.spec.tsStack