Skip to content

[Blueprints] Remove v2 experimental compatibility aliases - #4007

Merged
adamziel merged 2 commits into
trunkfrom
blueprint-v2-remove-experimental-aliases
Jul 11, 2026
Merged

[Blueprints] Remove v2 experimental compatibility aliases#4007
adamziel merged 2 commits into
trunkfrom
blueprint-v2-remove-experimental-aliases

Conversation

@adamziel

@adamziel adamziel commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What

Remove the retired Blueprint v2 opt-in aliases now that v2 declarations select the native TypeScript path automatically.

  • The hidden CLI --experimental-blueprints-v2-runner flag and its v1-option translations are gone.
  • WorkerBootOptions.experimentalBlueprintsV2Runner, which was already a no-op, is gone.
  • Personal WP no longer gives the retired query parameter special cleanup behavior.
  • Auto-mounted themes always emit the normal v1-shaped activation step; the v2 handler already owns the one required shape conversion.

Breaking change

Callers still passing --experimental-blueprints-v2-runner must remove it. Use a v2 declaration for automatic selection, or use --mode to choose create-new-site, apply-to-existing-site, or mount-only. Use --allow=follow-symlinks and --allow=read-local-fs for the capabilities the alias used to infer from old flags.

Code passing experimentalBlueprintsV2Runner in worker boot options must remove that property. It has had no effect since handler selection moved before worker boot.

Testing

  • npm exec -- nx run-many -t typecheck -p playground-cli playground-personal-wp playground-remote --parallel=3
  • npm exec -- nx run-many -t lint -p playground-cli playground-personal-wp playground-remote --parallel=3
  • npm exec -- nx run playground-cli:test-playground-cli --testFiles=mounts.spec.ts
  • npx vitest run --config packages/playground/cli/vite.config.ts packages/playground/cli/tests/run-cli.spec.ts -t "should reject the retired experimental v2 flag"
  • npm exec -- nx test playground-personal-wp --testFile=landing-page.spec.ts

Stack

  1. [Blueprints] Load v2 WordPress data-reference sources #4005
  2. [Website] Report Blueprint v2 analytics events #4006
  3. This PR
@adamziel
adamziel force-pushed the blueprint-v2-analytics-events branch from d066c65 to f44cb52 Compare July 10, 2026 23:55
@adamziel
adamziel force-pushed the blueprint-v2-remove-experimental-aliases branch from f8966a3 to f43f1c1 Compare July 10, 2026 23:55
@adamziel
adamziel force-pushed the blueprint-v2-analytics-events branch from f44cb52 to b30be8c Compare July 11, 2026 00:51
Base automatically changed from blueprint-v2-analytics-events to trunk July 11, 2026 09:48
@adamziel
adamziel requested review from a team and mho22 July 11, 2026 09:48
@adamziel
adamziel force-pushed the blueprint-v2-remove-experimental-aliases branch from f43f1c1 to b11910f Compare July 11, 2026 10:11
Copilot AI review requested due to automatic review settings July 11, 2026 10:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Removes the retired Blueprint v2 experimental compatibility aliases across CLI, worker boot options, and Personal WP URL handling now that v2 declarations automatically select the native TypeScript path.

Changes:

  • Drops the hidden CLI --experimental-blueprints-v2-runner flag and removes related handler-selection/translation logic.
  • Removes the no-op experimentalBlueprintsV2Runner worker boot option and stops stripping the retired query param from Personal WP URLs.
  • Updates/adjusts tests and auto-mount theme activation step emission to always use the v1-shaped step.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/playground/remote/src/lib/playground-worker-endpoint.ts Removes deprecated/no-op worker boot option.
packages/playground/personal-wp/src/lib/state/url/router.ts Stops stripping the retired v2 opt-in query parameter from URLs.
packages/playground/personal-wp/src/lib/state/url/landing-page.spec.ts Updates landing-page behavior expectation for retired query param.
packages/playground/cli/tests/run-cli.spec.ts Changes CLI test to assert the retired flag is rejected.
packages/playground/cli/tests/mounts.spec.ts Removes v2-runner-specific auto-mount step-shape test.
packages/playground/cli/src/run-cli.ts Removes CLI flag + translation logic and removes handler-selection alias branch.
packages/playground/cli/src/mounts.ts Always emits v1-shaped activateTheme step (themeFolderName).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/playground/cli/tests/run-cli.spec.ts Outdated
@adamziel
adamziel merged commit 367d865 into trunk Jul 11, 2026
51 checks passed
@adamziel
adamziel deleted the blueprint-v2-remove-experimental-aliases branch July 11, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment