[Blueprints] Execute every v2 schema variant in CI - #4014
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a schema-driven conformance suite to ensure every reachable Blueprint v2 schema variant validates and compiles, and tightens the font-related schema contract to only allow file references.
Changes:
- Added an occurrence-sensitive schema conformance test that walks the published v2 schema and asserts fixture coverage + successful compilation.
- Added dense fixtures intended to cover every reachable schema branch/variant.
- Tightened the v2 schema/validator so
fontsandfontFace.srcrequireFileDataReference(rejecting directory/git sources during validation).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/playground/blueprints/src/tests/v2/schema-conformance.spec.ts | New schema-walking conformance suite + compilation assertions. |
| packages/playground/blueprints/src/tests/v2/schema-conformance-fixtures.ts | New dense fixture set designed to cover all reachable schema variants. |
| packages/playground/blueprints/src/lib/v2/wep-1-blueprint-v2-schema/appendix-A-blueprint-v2-schema.ts | Tightens TypeScript schema types for fonts and fontFace.src to FileDataReference. |
| packages/playground/blueprints/public/blueprint-v2-schema-validator.js | Updates generated validator for FileDataReference changes. |
| packages/playground/blueprints/public/blueprint-schema.json | Updates published JSON schema for FileDataReference changes + regenerated aliases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
This PR adds CI tests to:
Other changes
Breaking schema change: font declarations now accept
FileDataReference, not directories or Git paths. The runner requires a file there, so the schema now rejects inputs it cannot execute.Testing instructions
CI :)