[Website] Center the modal loading spinner over the page - #4050
Merged
Conversation
github-actions
Bot
added
[Package][@wp-playground] Website
[Aspect] Browser
[Aspect] Website
and removed
[Package][@wp-playground] Website
labels
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the lazy modal loading fallback styling so it renders as a fixed, centered overlay instead of temporarily affecting the page’s flex layout while a modal chunk loads.
Changes:
- Convert the fallback container into a viewport-covering fixed overlay (
position: fixed; inset: 0) - Center fallback content via flex alignment in the overlay
- Add an explanatory comment describing the layout “blink” being avoided
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR centers the modal loading spinner over the page instead of adding a column on the left.
The modal loading spinner mounts as the first child of the page flex row. While a modal file loads, the spinner appears in a new column on the left.
Make the spinner a fixed overlay that fills the page and centers its contents. Its
z-indexmatches the WordPress modal that replaces it.This removes the left-side blink found while working on the Dock in #3965.
Verified with
npm exec nx test playground-website --output-style=staticandnpm exec nx typecheck playground-website --output-style=static.