[Website] Create blueprint.json for editable Blueprints that have none - #4052
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Seeds editable Blueprint bundles with a minimal blueprint.json so the Blueprint editor always has a file to open, while avoiding mutation of persisted/read-only bundles during inspection.
Changes:
- Added a minimal stub
blueprint.jsonand logic to ensure it exists for editable/in-memory filesystems. - Updated filesystem creation to optionally seed missing
blueprint.jsondepending on caller/read-only context. - Added Vitest coverage for
readSiteBlueprintJsonseeding and non-mutation behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/playground/website/src/components/blueprint-editor/SiteBlueprintBundleEditor.tsx | Adds stub blueprint seeding + optional behavior to avoid mutating persisted bundles when reading. |
| packages/playground/website/src/components/blueprint-editor/SiteBlueprintBundleEditor.spec.ts | Adds tests validating stub seeding and that reading doesn’t write into a filesystem backend. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a minimal
blueprint.jsonwhen an editable Blueprint has none.The Blueprint editor always reads
/blueprint.json. An editable Blueprint with no declaration or a bundle with no file leaves the editor with nothing to open.Create a minimal
blueprint.jsonwhen an editable filesystem does not have one. Do not write the file when reading a stored, read-only bundle.This gives the Blueprint editor a file to open when it moves into the Dock in #3965.
Verified with
npm exec nx test playground-website --output-style=staticandnpm exec nx typecheck playground-website --output-style=static.