[Website] Let Dock buttons be disabled and pane subtitles contain links - #4054
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds new “blocked/unavailable” UI states to Dock primitives (dock items + collapse control) and allows DockPane headers to render richer subtitle content, with accompanying rendering tests.
Changes:
- Add disabled styling for dock item buttons and dock toggle pill buttons.
- Introduce
collapseDisabledfor the collapse button andheaderSubtitlefor richer pane header content. - Add/extend rendering tests to cover the new states.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/playground/website/src/components/dock/style.module.css | Adds :disabled and :disabled:hover styling for dock items and pill buttons. |
| packages/playground/website/src/components/dock/dock-toggle-pill.tsx | Adds collapseDisabled prop, wiring to disabled + updated tooltip/title. |
| packages/playground/website/src/components/dock/dock-toggle-pill.spec.tsx | Adds a rendering test for collapse-disabled behavior. |
| packages/playground/website/src/components/dock/dock-pane.tsx | Adds headerSubtitle ReactNode to replace plain-text description rendering. |
| packages/playground/website/src/components/dock/dock-pane.spec.tsx | Adds test ensuring headerSubtitle replaces description. |
| packages/playground/website/src/components/dock/dock-item-button.tsx | Adds disabled prop and forwards it to the underlying <button>. |
| packages/playground/website/src/components/dock/dock-item-button.spec.tsx | Adds rendering test verifying the disabled attribute is present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets Dock buttons be disabled and lets pane subtitles contain React content.
The Dock needs to disable tool buttons and its collapse button while some actions are running. Those buttons did not accept a disabled state. Pane subtitles also accepted only plain text, so they could not contain a documentation link.
Add disabled props and disabled styles to the Dock buttons. Add a
headerSubtitleprop that accepts React content and keeps the normal subtitle spacing and text style. No current caller uses the new props.These props are needed by the Dock work in #3965.
Verified with
npm exec nx test playground-website --output-style=staticandnpm exec nx typecheck playground-website --output-style=static.