[Website] Separate Site Manager tool panels from its header - #4057
Merged
Conversation
This was referenced Jul 14, 2026
adamziel
force-pushed
the
dock-positioning-geometry
branch
from
July 15, 2026 00:06
9cbf297 to
bc03873
Compare
adamziel
force-pushed
the
site-tool-panels
branch
from
July 15, 2026 00:06
3775886 to
221f435
Compare
adamziel
added a commit
that referenced
this pull request
Jul 15, 2026
#4058) This PR lets the address bar stay visible but disabled while a Playground loads and makes its quick links work as an accessible keyboard listbox. The current quick-link menu moves keyboard focus out of the address field. The address field now remains the focused combobox. Up and Down select an option through `aria-activedescendant`, Enter opens it, and Escape closes the list. Pointer selection uses the same options without moving focus before the click. The new `disabled` property disables both the address field and refresh button, closes an open list, and keeps the displayed URL in sync. This lets #4009 keep the bottom Dock layout stable while there is no Playground client to navigate yet. The current address bar still opens its list below the field; #4009 will move it above the field when the bar moves to the bottom Dock. This is the third PR in the #4009 stack for #3965. It is based on #4057. Tested with: - `npm exec nx test playground-website -- --output-style=static` - `npm exec nx typecheck playground-website -- --output-style=static` - `npm exec nx lint playground-website -- --output-style=static`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the five Site Manager tool bodies out of
SiteInfoPanelwithout changing the current Site Manager UI.SiteInfoPanelcurrently owns two separate jobs: the Playground header and actions, and the Settings, File browser, Blueprint, Database, and Logs tab contents. The bottom Dock in #4009 needs those tool contents without the old header.SiteToolPanelsnow owns the existing tab contents.SiteInfoPanelstill owns the sameTabPanel, passes its selected tab into the new component, and renders the same tools with the same loading, offline, temporary-site, and read-only states. A focused test verifies that changing tabs hides inactive tools without unmounting them.This is the second PR in the #4009 stack for #3965. It is based on #4056.
Tested with:
npm exec nx test playground-website -- --output-style=staticnpm exec nx typecheck playground-website -- --output-style=staticnpm exec nx lint playground-website -- --output-style=static