Skip to content

[Website] Keep the Dock corner launcher clickable after dragging - #4059

Merged
adamziel merged 3 commits into
trunkfrom
dock-e2e-coverage
Jul 15, 2026
Merged

[Website] Keep the Dock corner launcher clickable after dragging#4059
adamziel merged 3 commits into
trunkfrom
dock-e2e-coverage

Conversation

@adamziel

Copy link
Copy Markdown
Collaborator

This keeps the Dock corner launcher clickable immediately after a drag and adds coverage for the missing desktop-corner and mobile-close flows.

#4009 suppresses the click synthesized after dragging so a drag cannot activate a Dock control. That listener was global. With reduced motion enabled, the corner launcher appears immediately, and its first click was swallowed even though the launcher is outside the Dock. This limits suppression to click targets inside the dragged Dock.

The Playwright tests now fold and reopen the desktop Dock, confirm an open pane prevents folding, close a mobile pane, and verify that closing returns focus to its Dock button and makes the preview interactive again. The flows pass in Chromium, Firefox, and WebKit.

This PR is stacked on #4009 so the production change and added coverage do not enlarge that PR.

Testing

  • Selected corner and mobile Playwright tests: 6/6 across Chromium, Firefox, and WebKit
  • npx nx run-many -t lint,typecheck,test -p playground-website: 57 test files, 303 tests
@adamziel
adamziel force-pushed the dock-e2e-coverage branch from 184b0a3 to 9493a1b Compare July 15, 2026 10:36
@adamziel
adamziel force-pushed the dock-ui-product-wiring branch from 838d40d to 9fccf8e Compare July 15, 2026 10:45
@adamziel
adamziel force-pushed the dock-e2e-coverage branch from 9493a1b to 1ea53b2 Compare July 15, 2026 10:45
@adamziel
adamziel force-pushed the dock-ui-product-wiring branch from 9fccf8e to 54bd711 Compare July 15, 2026 11:11
@adamziel
adamziel force-pushed the dock-e2e-coverage branch from 1ea53b2 to e6d0756 Compare July 15, 2026 11:11
@adamziel
adamziel force-pushed the dock-ui-product-wiring branch from 54bd711 to ae428a0 Compare July 15, 2026 11:38
@adamziel
adamziel force-pushed the dock-e2e-coverage branch 2 times, most recently from 48aafb2 to e4211b7 Compare July 15, 2026 11:56
@adamziel
adamziel force-pushed the dock-ui-product-wiring branch 2 times, most recently from 051cd97 to 90b647c Compare July 15, 2026 11:58
@adamziel
adamziel force-pushed the dock-e2e-coverage branch from e4211b7 to 2ab726e Compare July 15, 2026 11:58
Base automatically changed from dock-ui-product-wiring to trunk July 15, 2026 19:39
@adamziel
adamziel requested review from a team and mho22 July 15, 2026 19:39
@adamziel
adamziel force-pushed the dock-e2e-coverage branch from 2ab726e to f983c83 Compare July 15, 2026 20:14
Copilot AI review requested due to automatic review settings July 15, 2026 20:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Limits post-drag click suppression to clicks inside the Dock (so the corner launcher remains clickable immediately after dragging) and expands Playwright coverage for desktop-corner and mobile-close behaviors.

Changes:

  • Scope the “eatClick” suppression logic to Dock-contained click targets only.
  • Add a reduced-motion desktop test covering fold/restore and “pane open prevents folding”.
  • Extend mobile Dock test to verify closing a pane restores focus and re-enables the preview.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/playground/website/src/components/dock/dock.tsx Restricts synthesized-click suppression to targets inside the Dock element.
packages/playground/website/playwright/e2e/website-ui.spec.ts Adds/extends e2e coverage for desktop fold/restore and mobile pane close + focus/inert behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/playground/website/playwright/e2e/website-ui.spec.ts
Comment thread packages/playground/website/playwright/e2e/website-ui.spec.ts Outdated
@adamziel
adamziel merged commit d70d110 into trunk Jul 15, 2026
53 checks passed
@adamziel
adamziel deleted the dock-e2e-coverage branch July 15, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment