[Website] Keep the Dock corner launcher clickable after dragging - #4059
Merged
Conversation
adamziel
force-pushed
the
dock-e2e-coverage
branch
from
July 15, 2026 10:36
184b0a3 to
9493a1b
Compare
adamziel
force-pushed
the
dock-ui-product-wiring
branch
from
July 15, 2026 10:45
838d40d to
9fccf8e
Compare
adamziel
force-pushed
the
dock-e2e-coverage
branch
from
July 15, 2026 10:45
9493a1b to
1ea53b2
Compare
adamziel
force-pushed
the
dock-ui-product-wiring
branch
from
July 15, 2026 11:11
9fccf8e to
54bd711
Compare
adamziel
force-pushed
the
dock-e2e-coverage
branch
from
July 15, 2026 11:11
1ea53b2 to
e6d0756
Compare
adamziel
force-pushed
the
dock-ui-product-wiring
branch
from
July 15, 2026 11:38
54bd711 to
ae428a0
Compare
adamziel
force-pushed
the
dock-e2e-coverage
branch
2 times, most recently
from
July 15, 2026 11:56
48aafb2 to
e4211b7
Compare
adamziel
force-pushed
the
dock-ui-product-wiring
branch
2 times, most recently
from
July 15, 2026 11:58
051cd97 to
90b647c
Compare
adamziel
force-pushed
the
dock-e2e-coverage
branch
from
July 15, 2026 11:58
e4211b7 to
2ab726e
Compare
adamziel
force-pushed
the
dock-e2e-coverage
branch
from
July 15, 2026 20:14
2ab726e to
f983c83
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Limits post-drag click suppression to clicks inside the Dock (so the corner launcher remains clickable immediately after dragging) and expands Playwright coverage for desktop-corner and mobile-close behaviors.
Changes:
- Scope the “eatClick” suppression logic to Dock-contained click targets only.
- Add a reduced-motion desktop test covering fold/restore and “pane open prevents folding”.
- Extend mobile Dock test to verify closing a pane restores focus and re-enables the preview.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/playground/website/src/components/dock/dock.tsx | Restricts synthesized-click suppression to targets inside the Dock element. |
| packages/playground/website/playwright/e2e/website-ui.spec.ts | Adds/extends e2e coverage for desktop fold/restore and mobile pane close + focus/inert behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps the Dock corner launcher clickable immediately after a drag and adds coverage for the missing desktop-corner and mobile-close flows.
#4009 suppresses the click synthesized after dragging so a drag cannot activate a Dock control. That listener was global. With reduced motion enabled, the corner launcher appears immediately, and its first click was swallowed even though the launcher is outside the Dock. This limits suppression to click targets inside the dragged Dock.
The Playwright tests now fold and reopen the desktop Dock, confirm an open pane prevents folding, close a mobile pane, and verify that closing returns focus to its Dock button and makes the preview interactive again. The flows pass in Chromium, Firefox, and WebKit.
This PR is stacked on #4009 so the production change and added coverage do not enlarge that PR.
Testing
npx nx run-many -t lint,typecheck,test -p playground-website: 57 test files, 303 tests