[CI] Schedule asset refreshes before weekly deploy - #4065
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts the PHP Next and SQLite asset refresh workflows so scheduled runs prepare assets ahead of the existing Tuesday website deploy, instead of triggering an additional deploy workflow.
Changes:
- Move both workflows’
scheduletriggers to Tuesdays (PHP Next 06:00 UTC, SQLite 10:00 UTC). - Remove
actions: writepermissions and thebenc-uk/workflow-dispatchstep that previously triggereddeploy-website.yml. - Rename jobs to reflect the new behavior (build/publish/push without deploy).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/refresh-sqlite-integration.yml | Reschedules refresh to Tuesdays and removes the website deploy dispatch step/permissions. |
| .github/workflows/refresh-php-next.yml | Reschedules refresh to Tuesdays and removes the website deploy dispatch step/permissions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamziel
added
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The website deploy cadence is weekly on purpose. Deploying the public app more often invalidates caches and makes Playground reload code that did not need to move.
refresh-sqlite-integration.ymlwas bypassing that rule. A daily SQLite refresh could commit a new ZIP and immediately dispatchdeploy-website.yml. Some of those ZIP changes are just archive metadata churn, but they still produced real website deploys.refresh-php-next.ymldid the same every four days.This keeps the asset refreshes, but stops them from being deploy triggers. PHP Next now runs Tuesday at 06:00 UTC. SQLite now runs Tuesday at 09:00 UTC, which leaves two hours before the 11:00 UTC website deploy instead of racing its own 60-minute timeout. The existing website deploy picks up whatever those workflows published. Manual dispatch still works for both refresh workflows, but it refreshes assets only; it no longer deploys the website as a side effect.
Validated with:
git diff --check ruby -e 'require "yaml"; ARGV.each { |f| YAML.load_file(f); puts "parsed #{f}" }' .github/workflows/refresh-php-next.yml .github/workflows/refresh-sqlite-integration.yml