[Website] Animate the entire Dock pane when closing - #4066
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Keeps the full Dock pane surface rendered during the close animation so the exit transition mirrors the entrance (instead of collapsing to a header-only shell), and adds a regression e2e test to verify surface height stability during the first closing frame.
Changes:
- Retain the SiteManager pane body until the exit transition completes via a derived
paneContentVisibleflag. - Pass the derived visibility flag into
SiteManagerto prevent premature body collapse. - Add a Playwright regression test asserting pane height remains unchanged immediately after closing starts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/playground/website/src/components/dock/dock.tsx | Keeps pane content mounted through the exit transition by decoupling visibility from the open boolean. |
| packages/playground/website/playwright/e2e/website-ui.spec.ts | Adds an e2e regression test verifying the pane doesn’t collapse on the first close frame. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a Dock pane now keeps the full surface visible while its exit transition runs. The panel leaves as the reverse of its entrance instead of snapping down to a title-only shell first.
SiteManagerpreviously hid its body as soon assiteManagerIsOpenbecame false. The Dock now keeps that content rendered untilCSSTransitionreports the exit complete. The shell still becomes inert andaria-hiddenwhile it closes. A Playwright regression asserts that the pane height stays unchanged through the first closing frame.Testing:
npm exec nx -- run playground-website:typechecknpm exec nx -- run playground-website:lintnpm exec nx -- run playground-website:e2e:playwright -- --workers=3 --grep="whole Dock pane"(Chromium, Firefox, and WebKit)