Skip to content

[Website] Animate the entire Dock pane when closing - #4066

Merged
adamziel merged 3 commits into
trunkfrom
website-animate-dock-pane-close
Jul 15, 2026
Merged

[Website] Animate the entire Dock pane when closing#4066
adamziel merged 3 commits into
trunkfrom
website-animate-dock-pane-close

Conversation

@adamziel

Copy link
Copy Markdown
Collaborator

Closing a Dock pane now keeps the full surface visible while its exit transition runs. The panel leaves as the reverse of its entrance instead of snapping down to a title-only shell first.

SiteManager previously hid its body as soon as siteManagerIsOpen became false. The Dock now keeps that content rendered until CSSTransition reports the exit complete. The shell still becomes inert and aria-hidden while it closes. A Playwright regression asserts that the pane height stays unchanged through the first closing frame.

Testing:

  • npm exec nx -- run playground-website:typecheck
  • npm exec nx -- run playground-website:lint
  • npm exec nx -- run playground-website:e2e:playwright -- --workers=3 --grep="whole Dock pane" (Chromium, Firefox, and WebKit)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Keeps the full Dock pane surface rendered during the close animation so the exit transition mirrors the entrance (instead of collapsing to a header-only shell), and adds a regression e2e test to verify surface height stability during the first closing frame.

Changes:

  • Retain the SiteManager pane body until the exit transition completes via a derived paneContentVisible flag.
  • Pass the derived visibility flag into SiteManager to prevent premature body collapse.
  • Add a Playwright regression test asserting pane height remains unchanged immediately after closing starts.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
packages/playground/website/src/components/dock/dock.tsx Keeps pane content mounted through the exit transition by decoupling visibility from the open boolean.
packages/playground/website/playwright/e2e/website-ui.spec.ts Adds an e2e regression test verifying the pane doesn’t collapse on the first close frame.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/playground/website/src/components/dock/dock.tsx
Comment thread packages/playground/website/src/components/dock/dock.tsx Outdated
Comment thread packages/playground/website/playwright/e2e/website-ui.spec.ts
Comment thread packages/playground/website/playwright/e2e/website-ui.spec.ts Outdated
@adamziel
adamziel merged commit e0852dc into trunk Jul 15, 2026
53 checks passed
@adamziel
adamziel deleted the website-animate-dock-pane-close branch July 15, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment