[Website] Use graphite icons for dock pane actions - #4068
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates dock-pane action icons to use a softer “graphite” token instead of the accent blue, and ensures SVG glyphs inherit currentColor for consistent icon rendering.
Changes:
- Introduces an
--action-iconCSS variable and applies it to pane action icons. - Updates New Playground creation tab icon styles to follow
currentColor(viafill: currentColor). - Replaces accent-blue icon styling with graphite in Export / creation icon groups.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/playground/website/src/components/site-manager/site-share-panel/style.module.css | Switches action icon color from accent link to --action-icon token (with fallback). |
| packages/playground/website/src/components/saved-playgrounds-panel/style.module.css | Applies --action-icon to creation icons and makes SVGs inherit currentColor for consistent glyph coloring. |
| packages/playground/website/src/components/dock/style.module.css | Defines the --action-icon design token value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The New Playground and Export panes used bright blue for passive action-choice icons. That made them compete with the real accent affordances: primary buttons, links, focus rings, and status marks.
Use a soft graphite action-icon token for those pane action icons instead. The change applies it to the New Playground creation tabs and the Export option groups, and makes those SVGs follow
currentColorso the WordPress, GitHub, custom pull request, and stroke-based glyphs stay visually consistent.Testing:
git diff --check origin/trunk...HEADNot run:
nx formator package tests. This checkout has no Nx modules installed; the commit hook attemptednx format --fix --parallel --uncommittedand reported that Nx modules were missing.