[Website] Center the Playground file-loading message - #4072
Merged
Conversation
adamziel
force-pushed
the
adamziel/visible-loading-message
branch
from
July 15, 2026 21:55
08b96f8 to
30f3e17
Compare
adamziel
marked this pull request as ready for review
July 15, 2026 21:57
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Files pane loading state to be more prominent and readable while making the “boot wait” state explicit.
Changes:
- Centered and strengthened the pane loading UI (larger spinner, darker color, larger text).
- Adjusted layout CSS so the tools/panes can fill available height for proper vertical centering.
- Updated copy for the Files boot-time loading state and added a focused test locking that text.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/playground/website/src/components/spinner/style.module.css | Makes spinner color configurable via a CSS variable so it can inherit pane text color. |
| packages/playground/website/src/components/site-manager/site-info-panel/style.module.css | Adjusts flex/layout so tool content can expand and center loading state vertically. |
| packages/playground/website/src/components/site-manager/site-info-panel/site-tool-panels.tsx | Updates the Files tab boot-time loading message copy. |
| packages/playground/website/src/components/site-manager/site-info-panel/site-tool-panels.spec.tsx | Adds a test asserting the updated boot-time loading copy; refactors helper to accept a client override. |
| packages/playground/website/src/components/site-manager/site-info-panel/index.tsx | Adds a class hook for the tools container to support new layout rules. |
| packages/playground/website/src/components/pane-loading/style.module.css | Improves loading-state styling (color, type size/leading) and wires spinner color to currentColor. |
| packages/playground/website/src/components/pane-loading/index.tsx | Increases spinner size for better visibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Files pane now makes the boot wait obvious instead of showing a faint loader at the top of an otherwise empty pane.
The pane fills its available height and centers a larger dark spinner with the message “Playground files are still loading…”. The same loading-state component now uses readable 16px text, and a focused test locks the boot-time copy.
Tests
npm exec -- nx test playground-website --testFile=site-tool-panels.spec.tsxnpm exec -- nx typecheck playground-websitenpm exec -- nx lint playground-website