[CI] Fix NPM package publishing error - #4079
Merged
Merged
Conversation
Our NPM publishing workflow is currently broken because an install of `npm@latest` is bringing npm version 12.x which doesn't support the Node.js 20.x version we've selected. To stop the bleeding, let's explicitly install npm@11 so publishing works again. Using an explicit major NPM version is probably preferable anyway to avoid these kinds of issues in the future.
brandonpayton
added
the
[Type] Bug
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR fixes the broken NPM publishing GitHub Actions workflow by pinning npm to a compatible major version instead of installing npm@latest, which started resolving to an incompatible release.
Changes:
- Pin global npm upgrade step from
npm@latesttonpm@11for the publish workflow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Our NPM publishing workflow is currently broken because an install of
npm@latestis bringing npm version 12.x which doesn't support the Node.js 20.x version we've selected.Implementation details
To stop the bleeding, let's explicitly install npm@11 so publishing works again. Using an explicit major NPM version is probably preferable anyway to avoid these kinds of issues in the future.
Testing Instructions (or ideally a Blueprint)
Merge this one-line change and test. This isn't too risky since the workflow is already broken and the PR is just an npm version change.