[Website] Distinguish 404 errors from transient network failures - #4114
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Distinguishes “resource unavailable” (notably WordPress release 404s) from transient/network download failures, preserving the error identity across the worker boundary and surfacing a clearer, user-facing error modal.
Changes:
- Adds a new
resource-unavailableUI error type and maps worker-sideResourceUnavailableErrorto it. - Introduces a dedicated modal view to display concrete “unavailable” download messaging and a recovery action.
- Updates worker blueprint download logic and tests to treat HTTP 404 as a non-transient “unavailable” condition.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/playground/website/src/lib/state/redux/slice-ui.ts | Adds resource-unavailable to the SiteError union. |
| packages/playground/website/src/lib/state/redux/boot-site-client.ts | Classifies ResourceUnavailableError into the new UI error type. |
| packages/playground/website/src/lib/state/redux/boot-site-client.spec.ts | Adds test coverage for classifying worker “unavailable resource” errors. |
| packages/playground/website/src/components/site-error-modal/get-site-error-view.tsx | Routes resource-unavailable to a new modal view and prevents blueprint-step view from overriding it. |
| packages/playground/remote/src/lib/playground-worker-endpoint-blueprints.ts | Throws ResourceUnavailableError on WordPress download HTTP 404. |
| packages/playground/remote/src/lib/playground-worker-endpoint-blueprints.spec.ts | Expands tests to cover 200/404/500 behaviors and error identity/message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamziel
force-pushed
the
unavailable-wordpress-release-errors
branch
from
July 20, 2026 13:29
23e6033 to
4ecb8ca
Compare
adamziel
force-pushed
the
unavailable-wordpress-release-errors
branch
2 times, most recently
from
July 20, 2026 13:52
78ee80a to
9f496c4
Compare
A 404 from wordpress.org is not a transient network failure. Preserve that fact across the worker boundary and show the concrete download message through one generic unavailable-resource view. Other HTTP failures keep the existing download recovery.
adamziel
force-pushed
the
unavailable-wordpress-release-errors
branch
from
July 20, 2026 14:00
9f496c4 to
5484a04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4099.
A 404 from wordpress.org is not a transient network failure. Preserve that result across the worker boundary and show the concrete download message through one generic unavailable-resource view. Other HTTP failures keep the existing network guidance.
Testing
?wp=999.9.