[Website] Make desktop address suggestions clickable and input-width - #4135
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes desktop Dock address suggestion interactions by preventing Dock drag handling from capturing pointer events on the portaled suggestions list, and adjusts desktop popover sizing/positioning to match the URL input.
Changes:
- Treats the suggestions listbox as a Dock “control” so pointer sequences aren’t converted into Dock drags on desktop.
- Updates
AddressBarto acceptisMobileand sizes/offsets the popover differently on desktop vs mobile. - Adds a Playwright E2E test covering navigation via address bar suggestions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/playground/website/src/components/dock/dock.tsx | Expands “interactive target” detection to include the portaled listbox and wires isMobile into AddressBar. |
| packages/playground/website/src/components/address-bar/index.tsx | Implements desktop popover width/offset behavior and keeps width in sync on resize. |
| packages/playground/website/playwright/e2e/website-ui.spec.ts | Adds regression coverage for clicking address suggestions to navigate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Desktop address suggestions could not be clicked because their portaled listbox reached the floating Dock's pointer handler and was captured as a drag surface.
Implementation details
The Dock now treats the listbox as a control, so suggestion clicks retain their native pointer sequence. The desktop popover also follows the full URL input width and sits 8px above it. Mobile keeps its existing compact width and position.
Desktop
Mobile (unchanged)
Testing Instructions (or ideally a Blueprint)
On desktop, focus the URL input and click Dashboard. Confirm WordPress navigates to
/wp-admin/, the popover matches the input width, and a small gap separates them. Resize to mobile and confirm the compact popover layout still behaves as before.